Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate image pull secret at bootstrap #4621

Closed
Tracked by #4712
stefanprodan opened this issue Feb 21, 2024 · 0 comments · Fixed by #4706
Closed
Tracked by #4712

Generate image pull secret at bootstrap #4621

stefanprodan opened this issue Feb 21, 2024 · 0 comments · Fixed by #4706
Labels
area/bootstrap Bootstrap related issues and pull requests area/ux In pursuit of a delightful user experience

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Feb 21, 2024

To simplify the air-gapped bootstrap we could generate the image pull secret in the same way we do for the Git secret.

Example:

flux bootstrap git \
  --registry=registry.internal/fluxcd \
  --registry-creds="username:password" \
  --image-pull-secret="regcred"

When both the --registry-creds and --image-pull-secret are specified, we'll create or update the secret using the specified credentials. If --registry-creds is specified without --image-pull-secret, we'll error out and ask the user to supply the secret name.

The flux bootstrap --registry-creds input format is the same as for flux push artifact --creds, we can reuse the parsing logic and validation from --creds.

@stefanprodan stefanprodan added area/bootstrap Bootstrap related issues and pull requests area/ux In pursuit of a delightful user experience labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/ux In pursuit of a delightful user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant