Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle #2710

Closed
nojaf opened this issue Jan 13, 2023 · 3 comments
Closed

Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle #2710

nojaf opened this issue Jan 13, 2023 · 3 comments
Assignees
@dawedawe
Labels
good first issue Long hanging fruit: easy issue to get your feet wet! stroustrup v6

Comments

@nojaf
Copy link
Contributor

nojaf commented Jan 13, 2023

In #2658 we refactoredfsharp_multiline_block_brackets_on_same_column and fsharp_experimental_stroustrup_style into one setting fsharp_multiline_bracket_style.

For v6 we should remove all traces of the old settings and update the documentation.
@nojaf nojaf added good first issue Long hanging fruit: easy issue to get your feet wet! v6 labels Jan 13, 2023
@nojaf nojaf mentioned this issue Jan 13, 2023
Closed
10 tasks
@dawedawe dawedawe self-assigned this Jan 15, 2023
@dawedawe dawedawe mentioned this issue Jan 18, 2023
Merged
@josh-degraw josh-degraw mentioned this issue Jan 31, 2023
Merged
@josh-degraw
Copy link
Contributor

josh-degraw commented Jan 31, 2023 •
edited
Loading

Can this issue be closed now or are we still waiting on anything else for this? I guess are we still wanting to add a CLI warning if the old settings are used?

@nojaf
Copy link
Contributor Author

nojaf commented Feb 1, 2023

I typically close these issues after the official release, when everything is available on the main branch.

@nojaf
Copy link
Contributor Author

nojaf commented Apr 13, 2023

Available in v6.

@nojaf nojaf closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawedawe dawedawe

Labels
good first issue Long hanging fruit: easy issue to get your feet wet! stroustrup v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nojaf @dawedawe @josh-degraw