Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec keyword is removed from recursive modules #274

Closed
JonCanning opened this issue Jul 9, 2018 · 2 comments
Closed

rec keyword is removed from recursive modules #274

JonCanning opened this issue Jul 9, 2018 · 2 comments

Comments

@JonCanning
Copy link

module rec Foo becomes module Foo
@7sharp9
Copy link
Member

7sharp9 commented Jul 19, 2018 •
edited
Loading

I confirm, this is due to the isRec element of the ast being ignored:

fantomas/src/Fantomas/SourceParser.fs

Line 270 in fb120ed

| SynModuleDecl.NestedModule(SynComponentInfo.ComponentInfo(ats, _, _, LongIdent s, px, _, ao, _), _, xs, _, _) ->

parameter to the right of xs

Which is then used here in the code writer:

fantomas/src/Fantomas/CodePrinter.fs

Line 180 in 479b8ed

| NestedModule(ats, px, ao, s, mds) ->

@7sharp9
Copy link
Member

7sharp9 commented Jul 19, 2018

I got this one, PR incoming...

@7sharp9 7sharp9 mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@7sharp9 @JonCanning