Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Cleanup #73

Open
3 of 14 tasks
gggeek opened this issue Jul 29, 2019 · 1 comment
Open
3 of 14 tasks

API Cleanup #73

gggeek opened this issue Jul 29, 2019 · 1 comment
Labels
enhancement

Comments

@gggeek
Copy link
Owner

gggeek commented Jul 29, 2019 •
edited
Loading

At some point going forward, it might be worth doing a refactoring pass to modernize the existing API according to the usual oop best practices.

In no particular order:

  • use exceptions for invalid requests/responses
  • drop singleton-ness of helpers in favour of "proper" DIC; add interfaces for all helpers
  • introduce class constants for all existing 'magic' strings
  • add a Fault class ?
  • drop long-deprecated methods and functions
  • rename and simplify class internal members (eg. for Value and XMLParser)
  • move most public class members to protected access
  • move parseResponse method from the Request to the Client ?
  • move Encoder::decodeXml method to the XMLParser ?
  • allow for better parsing of big messages in memory-constrained cases by using streams by default instead of strings
  • issue Accessing generated XML #29
  • issue Please support more internal encodings than those of the xml parser. #42
  • issue Bump php-version to 5.6 / 7 #52
  • Roadmap? #6 (comment)
@gggeek
Copy link
Owner Author

gggeek commented Mar 4, 2020 •
edited
Loading

NB: there is also the rewrite going on in the "future-ng" branch...

@gggeek gggeek mentioned this issue Feb 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gggeek