Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofmt 1.11 fails for files that pass on 1.10 #26180

Closed
krasi-georgiev opened this issue Jul 2, 2018 · 2 comments
Closed

gofmt 1.11 fails for files that pass on 1.10 #26180

krasi-georgiev opened this issue Jul 2, 2018 · 2 comments

Comments

@krasi-georgiev
Copy link

What version of Go are you using (go version)?

1.10
1.11

our Travis CI runs the same tests agains 1.10 and 1.11 and since the last few days all test fail for some additional white space changes.

https://travis-ci.org/prometheus/prometheus/builds/399060443

If you notice the same passes under 1.10

the command that runs is
! gofmt -d $(find . -path ./vendor -prune -o -name '*.go' -print) | grep '^'
on https://github.com/prometheus/prometheus

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/krasi/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/krasi"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build023296472=/tmp/go-build -gno-record-gcc-switches"

@agnivade
Copy link
Contributor

agnivade commented Jul 2, 2018

I believe this is unfortunate. Looks similar to #25161.

@griesemer can confirm but I believe he is in vacation.

@krasi-georgiev
Copy link
Author

yep that looks like it. closing now and will look for a solution in the CI pipeline.

@golang golang locked and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants