Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting retry-request options #726

Closed
stephenplusplus opened this issue Feb 20, 2020 · 1 comment · Fixed by #879
Closed

Allow setting retry-request options #726

stephenplusplus opened this issue Feb 20, 2020 · 1 comment · Fixed by #879
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Feb 20, 2020

This library makes use of retry-request in streaming mode. However, retry-request allows options to be set which are not available through this library:

const retryStream = retryRequest(null, {

I'm not the best with this library -- @alexander-fenster, do you know how to make it possible so that from e.g. Bigtable, this would work:

const gaxClient = new v2[client](config);
const stream = gaxClient[method](reqOpts, gaxOpts, retryRequestOpts);

// or combined:
const gaxOpts = {
  retryRequestOptions: { ... },
};
const stream = gaxClient[method](reqOpts, gaxOpts);
@alexander-fenster
Copy link
Contributor

I think we can add retryRequestOptions to gax options (your combined option above).

@alexander-fenster alexander-fenster added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 20, 2020
@bcoe bcoe mentioned this issue Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants