File.save fails with Node 18.13.0

[buu700]

Environment details

• OS: Debian 11.6 aarch64
• Node.js version: 18.13.0
• npm version: 9.3.1
• @google-cloud/storage version: 6.9.0

Steps to reproduce

With a basic happy path usage of the library:

import {Storage} from '@google-cloud/storage';
const storage = new Storage(...).bucket(...);
await storage.file(...).save(...);

After upgrading from Node 18.12.1, I'm now getting the following error:

TypeError: RequestInit: duplex option is required when sending a body.
    at Object.fetch (node:internal/deps/undici/undici:14062:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  config: {
    method: 'PUT',
    url: 'https://storage.googleapis.com/upload/storage/v1/b/[redacted]',
    headers: {
      'x-goog-api-client': 'gl-node/18.13.0 gccl/6.9.0 gccl-invocation-id/[redacted]',
      'Content-Range': 'bytes 0-*/*',
      Authorization: 'Bearer [redacted]',
      Accept: 'application/json'
    },
    body: <ref *1> Readable {
      _readableState: ReadableState {
        objectMode: false,
        highWaterMark: 16384,
        buffer: BufferList { head: null, tail: null, length: 0 },
        length: 0,
        pipes: [],
        flowing: false,
        ended: false,
        endEmitted: false,
        reading: true,
        constructed: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: true,
        resumeScheduled: false,
        errorEmitted: false,
        emitClose: true,
        autoDestroy: true,
        destroyed: false,
        errored: null,
        closed: false,
        closeEmitted: false,
        defaultEncoding: 'utf8',
        awaitDrainWriters: null,
        multiAwaitDrain: false,
        readingMore: false,
        dataEmitted: true,
        decoder: null,
        encoding: null,
        [Symbol(kPaused)]: null
      },
      _read: [AsyncFunction: read],
      _events: [Object: null prototype] {
        readable: [Function (anonymous)],
        end: [Function (anonymous)],
        finish: [Function (anonymous)],
        error: [Function (anonymous)],
        close: [Function (anonymous)]
      },
      _eventsCount: 5,
      _maxListeners: undefined,
      __zone_symbol__readablefalse: [
        ZoneTask {
          _zone: Zone {
            _parent: null,
            _name: '<root>',
            _properties: {},
            _zoneDelegate: [_ZoneDelegate]
          },
          runCount: 2,
          _zoneDelegates: [],
          _state: 'scheduled',
          type: 'eventTask',
          source: 'Readable.addListener:readable',
          data: undefined,
          scheduleFn: [Function: customScheduleNonGlobal],
          cancelFn: [Function: customCancelNonGlobal],
          callback: [Function: next],
          invoke: [Function (anonymous)],
          options: undefined,
          target: [Circular *1],
          capture: false,
          eventName: 'readable'
        }
      ],
      __zone_symbol__endfalse: [
        ZoneTask {
          _zone: Zone {
            _parent: null,
            _name: '<root>',
            _properties: {},
            _zoneDelegate: [_ZoneDelegate]
          },
          runCount: 0,
          _zoneDelegates: [],
          _state: 'scheduled',
          type: 'eventTask',
          source: 'Readable.addListener:end',
          data: undefined,
          scheduleFn: [Function: customScheduleNonGlobal],
          cancelFn: [Function: customCancelNonGlobal],
          callback: [Function: onend],
          invoke: [Function (anonymous)],
          options: undefined,
          target: [Circular *1],
          capture: false,
          eventName: 'end'
        }
      ],
      __zone_symbol__finishfalse: [
        ZoneTask {
          _zone: Zone {
            _parent: null,
            _name: '<root>',
            _properties: {},
            _zoneDelegate: [_ZoneDelegate]
          },
          runCount: 0,
          _zoneDelegates: [],
          _state: 'scheduled',
          type: 'eventTask',
          source: 'Readable.addListener:finish',
          data: undefined,
          scheduleFn: [Function: customScheduleNonGlobal],
          cancelFn: [Function: customCancelNonGlobal],
          callback: [Function: onfinish],
          invoke: [Function (anonymous)],
          options: undefined,
          target: [Circular *1],
          capture: false,
          eventName: 'finish'
        }
      ],
      __zone_symbol__errorfalse: [
        ZoneTask {
          _zone: Zone {
            _parent: null,
            _name: '<root>',
            _properties: {},
            _zoneDelegate: [_ZoneDelegate]
          },
          runCount: 0,
          _zoneDelegates: [],
          _state: 'scheduled',
          type: 'eventTask',
          source: 'Readable.addListener:error',
          data: undefined,
          scheduleFn: [Function: customScheduleNonGlobal],
          cancelFn: [Function: customCancelNonGlobal],
          callback: [Function: onerror],
          invoke: [Function (anonymous)],
          options: undefined,
          target: [Circular *1],
          capture: false,
          eventName: 'error'
        }
      ],
      __zone_symbol__closefalse: [
        ZoneTask {
          _zone: Zone {
            _parent: null,
            _name: '<root>',
            _properties: {},
            _zoneDelegate: [_ZoneDelegate]
          },
          runCount: 0,
          _zoneDelegates: [],
          _state: 'scheduled',
          type: 'eventTask',
          source: 'Readable.addListener:close',
          data: undefined,
          scheduleFn: [Function: customScheduleNonGlobal],
          cancelFn: [Function: customCancelNonGlobal],
          callback: [Function: onclose],
          invoke: [Function (anonymous)],
          options: undefined,
          target: [Circular *1],
          capture: false,
          eventName: 'close'
        }
      ],
      [Symbol(kCapture)]: false
    },
    signal: AbortSignal {},
    validateStatus: [Function (anonymous)],
    paramsSerializer: [Function: paramsSerializer],
    responseType: 'json'
  }
}

Related issue: nodejs/node#46323

Edit: Replaced the internal Node stack trace with a more relevant error message (context here).

[shaffeeullah]

Hi @buu700 ,

This looks like a Node bug based on the issue you filed in the node repo. Will wait for that to be resolved and see if this issue persists.

[buu700]

A few notes:

• Passing in {resumable: false} seems to be an effective workaround for now

• Based on RequestInit: duplex option is required when sending a body nodejs/node#46221, it seems that this issue isn't expected to be fixed on Node's end

• Other projects have already started adding mitigations (TypeError: RequestInit: duplex option is required when sending a body. ipfs/js-ipfs#4276)

[ddelgrosso1]

@buu700 spent some time attempting to recreate this today without success. I tried with a few versions of Node >= 1.8.13.0. Are there any additional steps besides the ones in your original post? Could you provide an npm ls as well?

[ddelgrosso1]

As I have not been able to recreate this with several versions of Node >= 18.13.0 I am going to close this. If more information on recreation steps is available, please feel free to reopen.

[alexdao3]

@ddelgrosso1 I am currently running into this issue with node 18.17.0. With npm ls, I get the following:

├── @google-cloud/storage@7.1.0
├── firebase-admin@11.5.0
├── firebase-functions@4.4.1
├── firebase@10.7.1

[ddelgrosso1]

@alexdao3 if possible, can you either create a new issue or reopen this one with any info that might be helpful to repro the issue? Thanks!

[buu700]

Ah, thanks @alexdao3, and sorry I missed your comment last year @ddelgrosso1.