-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: VERSION_DETAILS does not contain the latest tag #2676
Comments
Potentially relevant issues: actions/checkout#882, actions/checkout#701 |
Decided to dig this a little deeper and we can actually see all of the In case that log disappears, I'll post the raw logs and a screenshot here as well: |
The question is, why was this not a problem in previous builds and became a problem for v0.40.0? 🤔 I assume I broke something with the (now notorious) #2591, but I am not sure exactly what... 😕 |
Was this same command executed in the previous releases? Or did something change in the github-action, maybe outside the changes in our workflow? |
I can guess that it's broken since, for the version details, we don't pass the Line 10 in 3e88e18
vs. Line 13 in 3e88e18
|
🤦♂️ Yeah, that is probably it... |
@olegbespalov tried it in a private repo and the lack of |
During the build the new tag hasn't been picked from the git describe command, in this way the
k6 version
prints an older tag. It isn't a critical bug because all the important information like the date or the commit hash are correct.The issue could be related to the GitHub checkout action that doesn't fetch for a strange reason the latest created tag.
Current
v0.39.0-92-gdcbe2f9c
Expected
v0.40.0-0-gdcbe2f9c
The text was updated successfully, but these errors were encountered: