Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures building 1.6.0 (x86_64 linux) #2519

Closed
daurnimator opened this issue Aug 19, 2020 · 10 comments · Fixed by #2836
Closed

Test failures building 1.6.0 (x86_64 linux) #2519

daurnimator opened this issue Aug 19, 2020 · 10 comments · Fixed by #2836

Comments

@daurnimator
Copy link

FAIL	github.com/grafana/loki/pkg/chunkenc [build failed]
    drop_test.go:373: validateDropConfig() error = drop stage invalid duration, 10y cannot be converted to a duration: time: unknown unit "y" in duration "10y", wantErr = drop stage invalid duration, 10y cannot be converted to a duration: time: unknown unit y in duration 10y
    --- FAIL: Test/invalid_idle_duration (0.00s)
FAIL	github.com/grafana/loki/pkg/logentry/stages	0.028s
@slim-bean
Copy link
Collaborator

I can't really explain why you are seeing this, our CI runs on the same architecture....

@daurnimator
Copy link
Author

FYI these errors were hit when trying to package 1.6.0 for archlinux (https://www.archlinux.org/packages/community/x86_64/loki/)

@slim-bean
Copy link
Collaborator

Thanks for the additional info, I'm still a bit stumped here but will try to take a closer look next week!

@jelly
Copy link

jelly commented Aug 23, 2020

Arch Linux builds with Go 1.15, maybe it has an incompatible change?

@slim-bean
Copy link
Collaborator

slim-bean commented Aug 23, 2020

Ooh that's an important detail, we haven't moved to 1.15 yet, 1.6 has only been built and tested with 1.14

@daurnimator
Copy link
Author

We'd like to get loki and logcli updated... do you need any extra info from us?

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 4, 2020
@daurnimator
Copy link
Author

Are we safe to ignore these test failures to get 1.6.x out to arch users?

loki-build.log

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Oct 7, 2020
@jelly
Copy link

jelly commented Oct 26, 2020

With 2.0.0, one test failed, which is now disabled in the Arch package build. https://gist.github.com/jelly/5c0f5db0e8e64169de51e60e29226510

@mweinelt
Copy link

@jelly How did you disable the test? The arch package is still on 1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants