Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version reported #8318

Closed
jgosmann opened this issue Jan 27, 2023 · 3 comments
Closed

Wrong version reported #8318

jgosmann opened this issue Jan 27, 2023 · 3 comments

Comments

@jgosmann
Copy link

Describe the bug
Since version 2.7.1, the version is incorrectly exported as branch reference and commit hash. Both when invoking loki-linux-amd64 -version and when looking at the loki_build_info metric.

For version 2.7.2, for example, I see the following:

loki, version HEAD-c35554d (branch: HEAD, revision: c35554d09)
  build user:       root@b28453c1a217
  build date:       2023-01-26T14:10:02Z
  go version:       go1.19.5
  platform:         linux/amd64

To Reproduce
Run loki-linux-amd64 -version.

OR: Look at the loki_build_info metric.

Expected behavior

First line of the loki-linux-amd64 -version output should be:

loki, version 2.7.2 (branch: HEAD, revision: c35554d09)

The version label of the loki_build_info metric should have the value 2.7.2.

Environment:

  • Infrastructure: virtual server
  • Deployment tool: Ansible downloading the Loki release from assets of the respective GitHub release.

Screenshots, Promtail config, or terminal output

$ /usr/local/sbin/loki-linux-amd64 -version
loki, version HEAD-c35554d (branch: HEAD, revision: c35554d09)
  build user:       root@b28453c1a217
  build date:       2023-01-26T14:10:02Z
  go version:       go1.19.5
  platform:         linux/amd64
@mytlogos
Copy link

Should already be fixed with #8232 (070e3ed).
Currently not released (see CHANGELOG.md on master)

@ashleykleynhans
Copy link

This is fixed in Loki 2.7.3 which was released today.

@jgosmann
Copy link
Author

jgosmann commented Feb 1, 2023

Can confirm that it is fixed. :)

@jgosmann jgosmann closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants