Fix needed to avoid Node Add/Update/Delete breaking in future version

[jeromy-cannon]

current code for solo node add/update/delete leverages the following directory:
.../data/upgrade/current
however, Nathan pointed out that NMT has always used the following:
../data/upgrade/current/data/keys

A patch has been made to the code, which is currently in develop for hashgraph/hedera-services: hashgraph/hedera-services@37d1891

My proposal is to check if the ../data/upgrade/current/data/keys directory exists, if so proceed with that, if not revert to the .../data/upgrade/current directory. Once we get past the versions with the bad directory v0.53 + v0.54? then we can remove the check.

[JeffreyDallas]

Do we still need this issue since we already updated to version 0.54 ?

[jeromy-cannon]

@JeffreyDallas , yes, it is still needed, I think it sometimes works because we copy the new keys to staging, but we really should be pulling them from the upgrade directory. It is sometimes causing me errors. Here is the sysout now that I'm using v0.54.0-alpha.4:

root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current# ls -al
total 28
drwxr-xr-x 3 root   root   4096 Sep 17 12:23 .
drwxr-xr-x 3 hedera hedera 4096 Sep 17 12:23 ..
-rw-r--r-- 1 root   root    520 Sep 17 12:23 config.txt
drwxr-xr-x 4 root   root   4096 Sep 17 12:23 data
-rw-r--r-- 1 root   root      3 Sep 17 12:23 execute_immediate.mf
-rw-r--r-- 1 root   root     10 Sep 17 12:23 freeze_scheduled.mf
-rw-r--r-- 1 root   root      3 Sep 17 12:23 now_frozen.mf
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current# cd data
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data# ls -al
total 16
drwxr-xr-x 4 root root 4096 Sep 17 12:23 .
drwxr-xr-x 3 root root 4096 Sep 17 12:23 ..
drwxr-xr-x 2 root root 4096 Sep 17 12:23 config
drwxr-xr-x 2 root root 4096 Sep 17 12:23 keys
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data# cd keys
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data/keys# l s-al
ls: cannot access 's-al': No such file or directory
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data/keys# ls -al
total 20
drwxr-xr-x 2 root root 4096 Sep 17 12:23 .
drwxr-xr-x 4 root root 4096 Sep 17 12:23 ..
-rw-r--r-- 1 root root 1464 Sep 17 12:23 s-public-node1.pem
-rw-r--r-- 1 root root 1464 Sep 17 12:23 s-public-node2.pem
-rw-r--r-- 1 root root 1464 Sep 17 12:23 s-public-node3.pem
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data/keys# cd ..
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data# ls -al
total 16
drwxr-xr-x 4 root root 4096 Sep 17 12:23 .
drwxr-xr-x 3 root root 4096 Sep 17 12:23 ..
drwxr-xr-x 2 root root 4096 Sep 17 12:23 config
drwxr-xr-x 2 root root 4096 Sep 17 12:23 keys
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data# ls -al config
total 12
drwxr-xr-x 2 root root 4096 Sep 17 12:23 .
drwxr-xr-x 4 root root 4096 Sep 17 12:23 ..
-rw-r--r-- 1 root root  417 Sep 17 12:23 application.properties
root@network-node1-0:/opt/hgcapp/services-hedera/HapiApp2.0/data/upgrade/current/data#

[swirlds-automation]

🎉 This issue has been resolved in version 0.30.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀