From 264395fbe90aec020754ff66eb884f10db158594 Mon Sep 17 00:00:00 2001 From: gunadhya <6939749+gunadhya@users.noreply.github.com> Date: Mon, 28 Dec 2020 16:51:02 +0530 Subject: [PATCH 1/2] fix in resource aws_msk_cluster enhanced_monitoring and client_broker using the AWS Go SDK _Values() --- aws/resource_aws_msk_cluster.go | 26 +++++++++----------------- tools/go.mod | 1 + tools/go.sum | 2 ++ 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/aws/resource_aws_msk_cluster.go b/aws/resource_aws_msk_cluster.go index e7805a4e8fe0..69bbecddb79c 100644 --- a/aws/resource_aws_msk_cluster.go +++ b/aws/resource_aws_msk_cluster.go @@ -190,15 +190,11 @@ func resourceAwsMskCluster() *schema.Resource { Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ "client_broker": { - Type: schema.TypeString, - Optional: true, - ForceNew: true, - Default: kafka.ClientBrokerTls, - ValidateFunc: validation.StringInSlice([]string{ - kafka.ClientBrokerPlaintext, - kafka.ClientBrokerTlsPlaintext, - kafka.ClientBrokerTls, - }, false), + Type: schema.TypeString, + Optional: true, + ForceNew: true, + Default: kafka.ClientBrokerTls, + ValidateFunc: validation.StringInSlice(kafka.ClientBroker_Values(), false), }, "in_cluster": { Type: schema.TypeBool, @@ -213,14 +209,10 @@ func resourceAwsMskCluster() *schema.Resource { }, }, "enhanced_monitoring": { - Type: schema.TypeString, - Optional: true, - Default: kafka.EnhancedMonitoringDefault, - ValidateFunc: validation.StringInSlice([]string{ - kafka.EnhancedMonitoringDefault, - kafka.EnhancedMonitoringPerBroker, - kafka.EnhancedMonitoringPerTopicPerBroker, - }, true), + Type: schema.TypeString, + Optional: true, + Default: kafka.EnhancedMonitoringDefault, + ValidateFunc: validation.StringInSlice(kafka.EnhancedMonitoring_Values(), true), }, "kafka_version": { Type: schema.TypeString, diff --git a/tools/go.mod b/tools/go.mod index 748e315d1bb3..0440c631e81a 100644 --- a/tools/go.mod +++ b/tools/go.mod @@ -7,6 +7,7 @@ require ( github.com/client9/misspell v0.3.4 github.com/golangci/golangci-lint v1.33.0 github.com/katbyte/terrafmt v0.2.1-0.20200913185704-5ff4421407b4 + github.com/pavius/impi v0.0.3 // indirect github.com/terraform-linters/tflint v0.20.3 ) diff --git a/tools/go.sum b/tools/go.sum index 1384a0fce441..76d6b9d5d225 100644 --- a/tools/go.sum +++ b/tools/go.sum @@ -640,6 +640,8 @@ github.com/onsi/gomega v1.10.2 h1:aY/nuoWlKJud2J6U0E3NWsjlg+0GtwXxgEqthRdzlcs= github.com/onsi/gomega v1.10.2/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo= github.com/packer-community/winrmcp v0.0.0-20180921211025-c76d91c1e7db/go.mod h1:f6Izs6JvFTdnRbziASagjZ2vmf55NSIkC/weStxCHqk= github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc= +github.com/pavius/impi v0.0.3 h1:DND6MzU+BLABhOZXbELR3FU8b+zDgcq4dOCNLhiTYuI= +github.com/pavius/impi v0.0.3/go.mod h1:x/hU0bfdWIhuOT1SKwiJg++yvkk6EuOtJk8WtDZqgr8= github.com/pborman/uuid v1.2.0/go.mod h1:X/NO0urCmaxf9VXbdlT7C2Yzkj2IKimNn4k+gtPdI/k= github.com/pelletier/go-toml v1.2.0 h1:T5zMGML61Wp+FlcbWjRDT7yAxhJNAiPPLOFECq181zc= github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic= From debd489494d9805fc5555d2b9666eefbc52469bf Mon Sep 17 00:00:00 2001 From: gunadhya <6939749+gunadhya@users.noreply.github.com> Date: Tue, 5 Jan 2021 02:07:01 +0530 Subject: [PATCH 2/2] Restore go mod and sum --- tools/go.mod | 1 - tools/go.sum | 2 -- 2 files changed, 3 deletions(-) diff --git a/tools/go.mod b/tools/go.mod index 0440c631e81a..748e315d1bb3 100644 --- a/tools/go.mod +++ b/tools/go.mod @@ -7,7 +7,6 @@ require ( github.com/client9/misspell v0.3.4 github.com/golangci/golangci-lint v1.33.0 github.com/katbyte/terrafmt v0.2.1-0.20200913185704-5ff4421407b4 - github.com/pavius/impi v0.0.3 // indirect github.com/terraform-linters/tflint v0.20.3 ) diff --git a/tools/go.sum b/tools/go.sum index 76d6b9d5d225..1384a0fce441 100644 --- a/tools/go.sum +++ b/tools/go.sum @@ -640,8 +640,6 @@ github.com/onsi/gomega v1.10.2 h1:aY/nuoWlKJud2J6U0E3NWsjlg+0GtwXxgEqthRdzlcs= github.com/onsi/gomega v1.10.2/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo= github.com/packer-community/winrmcp v0.0.0-20180921211025-c76d91c1e7db/go.mod h1:f6Izs6JvFTdnRbziASagjZ2vmf55NSIkC/weStxCHqk= github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc= -github.com/pavius/impi v0.0.3 h1:DND6MzU+BLABhOZXbELR3FU8b+zDgcq4dOCNLhiTYuI= -github.com/pavius/impi v0.0.3/go.mod h1:x/hU0bfdWIhuOT1SKwiJg++yvkk6EuOtJk8WtDZqgr8= github.com/pborman/uuid v1.2.0/go.mod h1:X/NO0urCmaxf9VXbdlT7C2Yzkj2IKimNn4k+gtPdI/k= github.com/pelletier/go-toml v1.2.0 h1:T5zMGML61Wp+FlcbWjRDT7yAxhJNAiPPLOFECq181zc= github.com/pelletier/go-toml v1.2.0/go.mod h1:5z9KED0ma1S8pY6P1sdut58dfprrGBbd/94hg7ilaic=