Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 16.6+: getDocumentFromComponent change #9

Closed
ItsJonQ opened this issue Jan 7, 2019 · 1 comment
Closed

React 16.6+: getDocumentFromComponent change #9

ItsJonQ opened this issue Jan 7, 2019 · 1 comment
Assignees
@ItsJonQ
Labels
bug Something isn't working

Comments

@ItsJonQ
Copy link
Contributor

ItsJonQ commented Jan 7, 2019 •
edited
Loading

react-utils/src/getDocumentFromComponent.js

Line 16 in 1374f12

if (Component._reactInternalFiber) {

This API may need to be updated for React 16.6+. I think the introduction of hooks changed the internals for how a React component instance stores their ties with DOM nodes.

Something like:

_reactInternalFiber._debugOwner.return.stateNode.ownerDocument
@ItsJonQ ItsJonQ added the bug Something isn't working label Jan 7, 2019
@ItsJonQ ItsJonQ self-assigned this Jan 7, 2019
@ItsJonQ ItsJonQ mentioned this issue Jan 7, 2019
Merged
@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented Jan 8, 2019

Resolved in #10

@ItsJonQ ItsJonQ closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsJonQ ItsJonQ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ItsJonQ