Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network broke with toolchain upgrade #158

Closed
mkroening opened this issue Sep 15, 2021 · 5 comments · Fixed by #159
Closed

Network broke with toolchain upgrade #158

mkroening opened this issue Sep 15, 2021 · 5 comments · Fixed by #159
Assignees
@mkroening

Comments

@mkroening
Copy link
Member

f667373 broke networking.

nightly-2021-07-01 works, but when building that one locally, it does not anymore. What am I doing wrong? 🤔
@stlankes
Copy link
Contributor

Fun fact, https://rusty-hermit.k8s.eonerc.rwth-aachen.de still works and is up-to-date (https://git.rwth-aachen.de/acs/public/hermitcore/rusty-hermit/-/pipelines).

@stlankes
Copy link
Contributor

Ah, I forgot that this version use RTL8132 as network interface.

@mkroening mkroening self-assigned this Sep 16, 2021
@mkroening
Copy link
Member Author

mkroening commented Sep 16, 2021 •
edited
Loading

Hacking around in my rustup installation, I found that the issue appeared first in nightly-2021-07-22: rust-lang/rust@b41936b...32c9b7b

@mkroening
Copy link
Member Author

The specific commit introducing the problem is an update to cargo: rust-lang/rust@f4981b4

@mkroening
Copy link
Member Author

The specific PR causing this change in behavior is rust-lang/cargo#9601.

@mkroening mkroening mentioned this issue Sep 16, 2021
Merged
@bors bors bot closed this as completed in a1a3157 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build.rs: Migrate to CARGO_ENCODED_RUSTFLAGS mkroening/rusty-hermit
2 participants
@stlankes @mkroening