Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out whether we need tini as pid1 in containers #891

Closed
make-github-pseudonymous-again opened this issue Apr 17, 2024 · 1 comment · Fixed by #893
Closed

Figure out whether we need tini as pid1 in containers #891

make-github-pseudonymous-again opened this issue Apr 17, 2024 · 1 comment · Fixed by #893
Labels
deploy This issue is about deployment docker This has to do with docker images and containers maybe This is just an idea and was not discussed.

Comments

@make-github-pseudonymous-again make-github-pseudonymous-again added maybe This is just an idea and was not discussed. deploy This issue is about deployment docker This has to do with docker images and containers labels Apr 17, 2024
@make-github-pseudonymous-again
Copy link
Contributor Author

Experiments show that without --init or init: true killing the web service times out. With --init or init: true, the web service is killed immediately. There is no need to use --init or init: true for mongo since it already properly forwards signals.

We could use --init or init: true to take care of potential bugs in mongo, but I have not seen this concern raised anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy This issue is about deployment docker This has to do with docker images and containers maybe This is just an idea and was not discussed.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant