Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-liner to run pytest and lint under Docker #85

Open
gabriel-v opened this issue Sep 7, 2023 · 0 comments · May be fixed by #86
Open

One-liner to run pytest and lint under Docker #85

gabriel-v opened this issue Sep 7, 2023 · 0 comments · May be fixed by #86

Comments

@gabriel-v
Copy link

gabriel-v commented Sep 7, 2023

Setting up an environment for the first time (following https://insitro.github.io/redun/developing.html) directly on the host has quite a few setbacks:

  • make setup
    • does not install/check for Java, needed for some federated/spark tests, installed implicitly in Ubuntu but not in Debian; this is not mentioned
    • need to find python3.10 or older, when package manager might have only 3.11
    • docs outdated; makefile rules make mypy and some others no longer exist. If this was a single entry script, docs would not need update as often

I see you already use docker-compose for the database, both in tests and examples. Why not use a docker/compose container to run the tests & examples too? The packaged dockerfile could serve as example for anyone trying to adapt it to their own hosts / containers.

So a new developer could just run ./pytest.sh -k filter --pdb and test what they are trying to patch in 5min, with 100% parity on the CI

I have a PR with some example scripts to start a discusison

@gabriel-v gabriel-v linked a pull request Sep 7, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant