Route update (HTTP PUT) modifies datastore entity by making it inconsistent

[denismakogon]

Route update (HTTP PUT) modifies datastore entity by making it inconsistent according to initial route info and requested fields to update.

Steps to reproduce:

• create route with type async
• list routes

ubuntu@ubuntu:~$ curl localhost:10501/v1/apps/testapp-68f72660931645198cd892/routes
{"message":"Sucessfully listed routes","routes":[{"app_name":"testapp-68f72660931645198cd892","path":"/hello","image":"iron/hello","memory":128,"type":"async","max_concurrency":1,"timeout":30,"config":{}}]}

• update route

ubuntu@ubuntu:~$ curl -X PUT localhost:10501/v1/apps/testapp-68f72660931645198cd892/routes/hello -d '{"route":{"type":"sync"}}'
{"message":"Route successfully updated","route":{"app_name":"testapp-68f72660931645198cd892","path":"/hello","type":"sync","config":null}}

• list routes

ubuntu@ubuntu:~$ curl localhost:10501/v1/apps/testapp-68f72660931645198cd892/routes
{"message":"Sucessfully listed routes","routes":[{"app_name":"testapp-68f72660931645198cd892","path":"/hello","image":"iron/hello","type":"sync","timeout":30,"config":{}}]}

• get route info

ubuntu@ubuntu:~$ curl localhost:10501/v1/apps/testapp-68f72660931645198cd892/routes/hello
{"message":"Successfully loaded route","route":{"app_name":"testapp-68f72660931645198cd892","path":"/hello","image":"iron/hello","type":"sync","timeout":30,"config":{}}}

So there are two problems:

• route update response doesn't match to what swagger doc describes along with showing inconsistent info (in particular case - config attributes are not equal (null vs {})
• route update (HTTP PUT) makes route datastore entity inconsistent (max_concurrency is missing)