New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-video should be a peer-dependency #30

Closed

lopezjurip opened this issue Jul 10, 2017 · 1 comment

Contributor

lopezjurip commented Jul 10, 2017

Well done 👍
But I think that react-native-video should be a peer-dependency instead of a normal dependency.
See https://nodejs.org/en/blog/npm/peer-dependencies/

lopezjurip mentioned this issue

Change react-native-video to a peer-dependency #31

Merged

Contributor

kylemilloy commented Jul 19, 2017

Looks good.

kylemilloy closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment