Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint solver limitation known problem test and a workaround #503

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

erszcz
Copy link
Collaborator

@erszcz erszcz commented Jan 12, 2023

This documents a limitation of the constraint solver using intersection typed functions' return values as lower bounds, which leads to false positives. It's a tricky case, but I tried to describe it in the added test case. I'm not sure yet if it's possible to fix it with the current solver implementation.

@erszcz erszcz changed the title Constraint solver limitation Constraint solver limitation known problem test and a workaround Jan 12, 2023
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, interesting.

test/known_problems/should_pass/poly_should_pass.erl Outdated Show resolved Hide resolved
@erszcz erszcz merged commit ce6e3d1 into josefs:master Jan 13, 2023
@erszcz erszcz deleted the constraint-solver-limitation branch January 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants