Add apps option to rebar3 commands
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalobf
force-pushed
the
gonzalo-add-apps-option
branch
from
aa75467
to
7c7aeae
Compare
|
Hi, @gonzalobf! Thanks for the PR - it's a great idea! The CI is almost good, the only non-passing check is Gradualizer itself. Could you take a look at it? These errors: are ignored in |
gonzalobf
force-pushed
the
gonzalo-add-apps-option
branch
from
7c7aeae
to
210be40
Compare
gonzalobf
commented
May 8, 2023
gonzalobf
force-pushed
the
gonzalo-add-apps-option
branch
from
210be40
to
d97a8eb
Compare
This option allows to specify a list of apps where to run the type check. The list can be specify when running the command or in `rebar.config`. This option can be really handy when trying to integrate Gradualizer on big umbrella project. If the project contains a lot of errors, it is possible to enable the type check app by app and fix the errors incrementally.
gonzalobf
force-pushed
the
gonzalo-add-apps-option
branch
from
d97a8eb
to
1634767
Compare
|
@erszcz Thank you. I think I have fixed the tests. Could you please run the workflow? |
|
Looks good to me, great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows to specify a list of apps where to run the type check. The list can be specify when running the command or in
rebar.config.This option can be really handy when trying to integrate Gradualizer on big umbrella project. If the project contains a lot of errors, it is possible to enable the type check app by app and fix the errors incrementally.