Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Styling Proposal #728

Closed
mlucool opened this issue Aug 13, 2020 · 0 comments · Fixed by #763
Closed

Python Styling Proposal #728

mlucool opened this issue Aug 13, 2020 · 0 comments · Fixed by #763
Labels
maintenance pkg:Server Extension

Comments

@mlucool
Copy link
Contributor

mlucool commented Aug 13, 2020

Hi,

I'd like to propose we move all python code to be styled by black. It will increase readability across the code base IMO. The downside is black is not at 1.0 yet, but we can run black just on changed files and set minimum versions in setup.py (see projects using black).

What do others think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance pkg:Server Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format code using black ianhi/jupyterlab-git
3 participants
@mlucool @fcollonval @ianhi