Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the service name be advertised under Windows? #83

Closed
paulhamsh opened this issue Jun 10, 2022 · 2 comments
Closed

Should the service name be advertised under Windows? #83

paulhamsh opened this issue Jun 10, 2022 · 2 comments
Assignees
Labels
backend: WinRT Problem specific to WinRT

Comments

@paulhamsh
Copy link

The problem
my_service_name doesn't seem to show in LightBlue when using Windows - it shows as the Windows device name

Reproduction
my_service_name = "Sparksy"
server = BlessServer(name=my_service_name)

Expected behavior
Show as Sparksy

Desktop (please complete the following information):

  • OS: Windows 10, using tp-link external bluetooth dongle (UB500)

Is it supposed to work under Windows 10?

@paulhamsh paulhamsh changed the title Should the service name be advertised under Windows Should the service name be advertised under Windows? Jun 10, 2022
@Jakeler
Copy link
Contributor

Jakeler commented Jun 26, 2022

No, the passed name is currently unused:
https://github.com/kevincar/bless/blob/v0.2.4/bless/backends/winrt/server.py#L64
Would have to check if it is possible to implement it with WinRT.
It should work on Linux and Mac though.

@kevincar kevincar added the backend: WinRT Problem specific to WinRT label Aug 13, 2022
@kevincar kevincar self-assigned this Aug 26, 2022
@kevincar
Copy link
Owner

As far as I can tell, WinRT doesn't allow custom changes to local_name property that is broadcast. I've implemented more of a workaround rather than a true solution, by manipulating the name of the Windows Bluetooth module device.

This results in changes to the name of the bluetooth device as it is listed in the Windows Registery Key, and thus requires that you run bless with elevated privileges or set user access to the specific bluetooth properties key that allows for name changes

Closing this for now with this work around. Merged into the develop branch for now with merge #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: WinRT Problem specific to WinRT
Projects
None yet
Development

No branches or pull requests

3 participants