Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplatform NodeJS Http Client. #782

Closed
EltonZhong opened this issue Dec 11, 2018 · 8 comments
Closed

Multiplatform NodeJS Http Client. #782

EltonZhong opened this issue Dec 11, 2018 · 8 comments
Assignees
@e5l
Labels
enhancement help wanted

Comments

@EltonZhong
Copy link
Contributor

When will node js HTTP client be released?
@EltonZhong EltonZhong changed the title Multiplatform JS Http Client. Multiplatform NodeJS Http Client. Dec 11, 2018
@EltonZhong
Copy link
Contributor Author

js-client use window.fetch api, which is not supported in node.js.

@EltonZhong
Copy link
Contributor Author

Have you got a solution or plan for this? Have I missed anything in the document? BTW, I'm glad to contribute the node-js support.

@cy6erGn0m
Copy link
Contributor

Doesn't node-fetch provide fetch implementation?

@e5l e5l self-assigned this Dec 12, 2018
@e5l
Copy link
Member

e5l commented Dec 12, 2018

Hi, @EltonZhong. We're not focusing on node client for now, but we would really happy to accept the PR.

@EltonZhong
Copy link
Contributor Author

Doesn't node-fetch provide fetch implementation?

Yes

@EltonZhong
Copy link
Contributor Author

Hi, @EltonZhong. We're not focusing on node client for now, but we would really happy to accept the PR.

OK, working on it.

@EltonZhong
Copy link
Contributor Author

Hi @e5l , Could you please have a look at #791 ?
The node.js support for js-client based on 'node-fetch'.

@e5l
Copy link
Member

e5l commented Dec 26, 2018

Merged

@e5l e5l closed this as completed Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e5l e5l

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cy6erGn0m @e5l @EltonZhong