Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete GCE integration #8169

Closed
lmercl opened this issue Nov 8, 2021 · 3 comments · Fixed by #8179
Closed

Complete GCE integration #8169

lmercl opened this issue Nov 8, 2021 · 3 comments · Fixed by #8179
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lmercl
Copy link
Contributor

lmercl commented Nov 8, 2021

Hello,
looks like kubespray doesn't have finished integration to GCE.

Basically there is needed 2 things:

  1. creating PVs - already done by csi-gce-pd-controller,
  2. creating LB resources - not finished - not working with current kubespray code

Creating LB resources
My deployed stack has set cloud_provider: gce, and it works for PVs (with good config), but LBs are not working. Basically I'm able to resolved with editing /etc/kubernetes/manifests/kube-controller-manager.yaml by adding two the new params:

    - --cloud-provider=gce
    - --cloud-config=/etc/kubernetes/cloud-config

This can be resolved by adding gce to this (and similar) IFs:

{% if cloud_provider is defined and cloud_provider in ["openstack", "azure", "vsphere", "aws"] %}

Basically it's only add cloud-provider options to GCE and create file with configs.
I'm not sure if there will be some more integration needed, but not working LBs can be resolved only by this.

@lmercl lmercl added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 8, 2021
@floryut
Copy link
Member

floryut commented Nov 8, 2021

Thanks for the issue, maybe open up a PR with that ?
I guess you have to change at least all checks in kubeadm-config.v1beta2.yaml (L200/217?/219/293/310/317)

And maybe

{% if cloud_provider is defined and cloud_provider in ["openstack", "azure", "vsphere", "aws", "external"] %}

@lmercl
Copy link
Contributor Author

lmercl commented Nov 8, 2021

@floryut Yeah, I can open up a PR with that. I'm woking on it right now.
Thanks for hints.

@lmercl
Copy link
Contributor Author

lmercl commented Nov 10, 2021

Hello @floryut,
PR is created. Please let me know when something will be needed to add or changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants