-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-current not working #311
Comments
What's If you're using request()->routeIs('vault.cms.pages.*') This would match all routes under the Ps. for us not-contributors trying to help, can you include a reference to the old issue? It saves some time searching for it. |
here's the ref #284 From what I understood, flux is doing it automatically. It does work with hardcoded links (ie vault/cms/pages/...) but not with named routes. I've been told it's been fixed in the latest update (which I installed) but it still doesn't work and I suspect it might be because of the extra domain route/group. |
There may be situations where it doesn't work like you expect. E.g. multi-tenant applications or apps with sub-domains. If it doesn't work, there may be something that breaks it for you. Personally I wouldn't be bothered about it and just use |
I don't see what the issue is. This is working fine in my test environment.
Route::name('admin.')->domain('localhost')->group(function () {
Volt::route('/', 'foo')->name('foo');
Volt::route('/bar', 'bar')->name('bar');
});
<flux:navlist variant="outline">
<flux:navlist.item icon="home" href="{{ route('admin.foo') }}">Foo</flux:navlist.item>
<flux:navlist.item icon="inbox" badge="12" href="{{ route('admin.bar') }}">Bar</flux:navlist.item>
</flux:navlist> |
@idealerror something must be different in your test set-up, perhaps your I've just tested this on a fresh installation with Laravel Herd by linking two domains to one installation. The menu item is only marked as current when I'm on the For 99% of the apps out there Flux does exactly what you expect. But there are situations where it doesn't work, and that's fine. |
Sorry for the repost but you closed the previous issue too soon...
Documentation lacks how to properly implement the active menu.
Currently, I can't figure out how to have it recognise the current path. It stays on the root.
Routes
Menu (on layout) - how to dynamically set the current on the nabber item
I already did remove the "current".
I also updated flux to 1.0.8
I still have the issue.
I'm wondering if this has to do with the domain/nested route ?
The text was updated successfully, but these errors were encountered: