Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] Cmov converter pass sinks volatile loads #42267

Open
topperc opened this issue Aug 7, 2019 · 0 comments
Open

[X86] Cmov converter pass sinks volatile loads #42267

topperc opened this issue Aug 7, 2019 · 0 comments
Labels
backend:X86 bugzilla Issues migrated from bugzilla

Comments

@topperc
Copy link
Collaborator

topperc commented Aug 7, 2019

Bugzilla Link 42922
Version trunk
OS Windows NT
CC @topperc,@RKSimon,@rotateright,@TNorthover

Extended Description

When the cmov converter pass expands a volatile load that has been folded with a cmov, it places the load only on the false path of the created control flow. But a volatile load should be executed unconditionally. The original cmov instruction would have always executed the load.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

1 participant