-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] Eliminate AspectMock from ObjectExtensionUtilTest (Complex!) #33305
Labels
Priority: P1
Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.
Progress: done
Project: PHP8
Project: Platform Health
Comments
m2-community-project
bot
added
Progress: dev in progress
and removed
Progress: ready for dev
labels
Jun 23, 2021
m2-community-project
bot
added
Progress: ready for dev
and removed
Progress: dev in progress
labels
Jun 28, 2021
sivaschenko
added
the
Priority: P1
Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.
label
Jun 28, 2021
@magento I am working on this |
m2-community-project
bot
added
Progress: dev in progress
and removed
Progress: ready for dev
labels
Jun 30, 2021
@magento export issue to Jira project AC as Story |
✅ Jira issue https://jira.corp.magento.com/browse/AC-320 is successfully created for this GitHub issue. |
m2-community-project
bot
added
Progress: ready for dev
and removed
Progress: dev in progress
labels
Jul 1, 2021
@magento I am working on this |
m2-community-project
bot
added
Progress: dev in progress
and removed
Progress: ready for dev
labels
Jul 3, 2021
5 tasks
m2-community-project
bot
added
Progress: PR in progress
and removed
Progress: dev in progress
labels
Jul 14, 2021
Pull request is merged in develop |
m2-community-project
bot
added
Progress: done
and removed
Progress: PR in progress
labels
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: P1
Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.
Progress: done
Project: PHP8
Project: Platform Health
This task is tricky and requires investigation on the approach to mock static calls without Aspect Mock
Goal
codeception/aspect-mock
library is still not compatible with PHP 8.0 at the time of the creation of this ticket.To speed up Magento compatibility with new PHP versions we'd like to eliminate
codeception/aspect-mock
dependency from MFTF. This will make MFTF compatible with PHP 8.0 that is required for declaring the Magento core PHP 8 compatible as well.In order to do this existing unit tests using AspectMock should be refactored to use PHPUnit instead.
Task
Eliminate AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/Test/Util/ObjectExtensionUtilTest.php
in https://github.com/magento/magento2-functional-testing-framework repository.Example
Mocking an object using AspectMock (current):
Mocking an object using PHPUnit (refactored code):
Example pull request: magento/magento2-functional-testing-framework#833
The text was updated successfully, but these errors were encountered: