Magento 2.4.5-p1 Reorder issue

[niku0911]

Reorder having an issue with Custom option Product

Preconditions (*)
Magento version: 2.4.5-p1

Steps to reproduce (*)

1. Create a simple product with a custom option
   
2. Create an account on frontend then order that product
3. go to my order and click to reorder it's showing an error
   

Expected result (*)

1. Need to reorder with same data

Actual result (*)

1. As per checked no custom option information showing in the order
   

[m2-assistant]

Hi @niku0911. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://c13daff8daa43ce9bc703e6cf12ae422.instances.magento-community.engineering
Admin access: https://c13daff8daa43ce9bc703e6cf12ae422.instances.magento-community.engineering/admin_d605
Login: 584274b9
Password: 2b68004255fa

[engcom-Bravo]

Hi @niku0911,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible. Kindly refer the screenhsots.

Steps to reproduce

1.Create a simple product with a custom option
2.Create an account on frontend then order that product
3.go to my order and click to reorder it's showing an error.

We are able to reorder the same product without any error.

Kindly recheck the behavior on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[FadedOut]

@niku0911 what does the log say for the error? The log will be located as a file on the server here: /public_html/var/log/system.log

For future reference, always post the log (just the error at the time though, no need to post the whole thing), it helps others help you.

[niku0911]

HI @FadedOut
we got below error on system log

[2023-01-13T04:42:49.028492+00:00] main.CRITICAL: TypeError: Magento\Framework\DataObject::__construct(): Argument #1 ($data) must be of type array, null given, called in /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Model/Reorder/OrderInfoBuyRequestGetter.php on line 65 and defined in /home/awarenessplace/public_html/uat/vendor/magento/framework/DataObject.php:39
Stack trace:
#0 /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Model/Reorder/OrderInfoBuyRequestGetter.php(65): Magento\Framework\DataObject->__construct()
#1 /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Model/Reorder/Reorder.php(255): Magento\Sales\Model\Reorder\OrderInfoBuyRequestGetter->getInfoBuyRequest()
#2 /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Model/Reorder/Reorder.php(217): Magento\Sales\Model\Reorder\Reorder->addItemToCart()
#3 /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Model/Reorder/Reorder.php(161): Magento\Sales\Model\Reorder\Reorder->addItemsToCart()
#4 /home/awarenessplace/public_html/uat/vendor/magento/module-sales/Controller/AbstractController/Reorder.php(87): Magento\Sales\Model\Reorder\Reorder->execute()
#5 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Sales\Controller\AbstractController\Reorder->execute()
#6 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Sales\Controller\Order\Reorder\Interceptor->___callParent()
#7 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Sales\Controller\Order\Reorder\Interceptor->Magento\Framework\Interception{closure}()
#8 /home/awarenessplace/public_html/uat/generated/code/Magento/Sales/Controller/Order/Reorder/Interceptor.php(23): Magento\Sales\Controller\Order\Reorder\Interceptor->___callPlugins()
#9 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/Action/Action.php(111): Magento\Sales\Controller\Order\Reorder\Interceptor->execute()
#10 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Action\Action->dispatch()
#11 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Sales\Controller\Order\Reorder\Interceptor->___callParent()
#12 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Sales\Controller\Order\Reorder\Interceptor->Magento\Framework\Interception{closure}()
#13 /home/awarenessplace/public_html/uat/generated/code/Magento/Sales/Controller/Order/Reorder/Interceptor.php(32): Magento\Sales\Controller\Order\Reorder\Interceptor->___callPlugins()
#14 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/FrontController.php(245): Magento\Sales\Controller\Order\Reorder\Interceptor->dispatch()
#15 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse()
#16 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest()
#17 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch()
#18 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent()
#19 /home/awarenessplace/public_html/uat/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(99): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}()
#20 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(135): Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch()
#21 /home/awarenessplace/public_html/uat/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(71): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}()
#22 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(135): Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch()
#23 /home/awarenessplace/public_html/uat/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}()
#24 /home/awarenessplace/public_html/uat/generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins()
#25 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch()
#26 /home/awarenessplace/public_html/uat/generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http->launch()
#27 /home/awarenessplace/public_html/uat/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#28 /home/awarenessplace/public_html/uat/pub/index.php(30): Magento\Framework\App\Bootstrap->run()
#29 {main} [] []

[FadedOut]

@magento give me 2.4.5-p1 instance

[magento-deployment-service]

Hi @FadedOut. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @FadedOut, here is your Magento Instance: https://6dfb7d1c90e1542c32219ccbf960c8a5.instances.magento-community.engineering
Admin access: https://6dfb7d1c90e1542c32219ccbf960c8a5.instances.magento-community.engineering/admin_838b
Login: f5964b3c
Password: c88e37fffa1b

[FadedOut]

@niku0911 Hmm so unfortunately, I may not be able to help - and I hate that :(. I wish I could have given you solution, I was hoping maybe it was because you had it set to 0 characters that maybe it was bugging out - but I copied your custom field exactly and it went through. I'll attach the screenshots and video of my test. And the log you posted I'm not sure why it would be throwing that.

So you say that the order goes through the first time, but the custom field doesn't show on the order screen (as your screenshot shows)....that is odd, esp that there is no error on the frontend from the first time the order was placed and succeeded only during re-order. Is there any error in the log when you place the order (the first time - not the reorder)? I've had errors appear in the log but show no sign of an error on the UI side.

magento-github-topic-reorder-test-video-1.mp4

[niku0911]

Hi @FadedOut,

so might be an issue with 3rd party extension, will check this on our side on this.

[SerhiiMandrykin]

Hi. We have almost the same problem, but the log is:

InvalidArgumentException: Unable to unserialize value. Error: Syntax error in /magento2/vendor/magento/framework/Serialize/Serializer/Json.php:45
Stack trace:
#0 /magento2/vendor/magento/module-sales/Model/Reorder/OrderInfoBuyRequestGetter.php(56): Magento\Framework\Serialize\Serializer\Json->unserialize('Laurine')
#1 /magento2/vendor/magento/module-sales/Model/Reorder/Reorder.php(255): Magento\Sales\Model\Reorder\OrderInfoBuyRequestGetter->getInfoBuyRequest(Object(Magento\Sales\Model\Order\Item\Interceptor))
#2 /magento2/vendor/magento/module-sales/Model/Reorder/Reorder.php(217): Magento\Sales\Model\Reorder\Reorder->addItemToCart(Object(Magento\Sales\Model\Order\Item\Interceptor), Object(Magento\Quote\Model\Quote\Interceptor), Object(Magento\Catalog\Model\Product\Interceptor))
#3 /magento2/vendor/magento/module-sales/Model/Reorder/Reorder.php(161): Magento\Sales\Model\Reorder\Reorder->addItemsToCart(Object(Magento\Quote\Model\Quote\Interceptor), Array, '13')
#4 /magento2/vendor/magento/module-sales/Controller/AbstractController/Reorder.php(87): Magento\Sales\Model\Reorder\Reorder->execute('13******103', '13')
#5 /magento2/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Sales\Controller\AbstractController\Reorder->execute()
#6 /magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Sales\Controller\Order\Reorder\Interceptor->___callParent('execute', Array)
#7 /magento2/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Sales\Controller\Order\Reorder\Interceptor->Magento\Framework\Interception\{closure}()
#8 /magento2/generated/code/Magento/Sales/Controller/Order/Reorder/Interceptor.php(23): Magento\Sales\Controller\Order\Reorder\Interceptor->___callPlugins('execute', Array, Array)
#9 /magento2/vendor/magento/framework/App/Action/Action.php(111): Magento\Sales\Controller\Order\Reorder\Interceptor->execute()
#10 /magento2/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
#11 /magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Sales\Controller\Order\Reorder\Interceptor->___callParent('dispatch', Array)
#12 /magento2/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Sales\Controller\Order\Reorder\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#13 /magento2/generated/code/Magento/Sales/Controller/Order/Reorder/Interceptor.php(32): Magento\Sales\Controller\Order\Reorder\Interceptor->___callPlugins('dispatch', Array, Array)
#14 /magento2/vendor/magento/framework/App/FrontController.php(245): Magento\Sales\Controller\Order\Reorder\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#15 /magento2/vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse(Object(Magento\Sales\Controller\Order\Reorder\Interceptor), Object(Magento\Framework\App\Request\Http))
#16 /magento2/vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest(Object(Magento\Framework\App\Request\Http), Object(Magento\Sales\Controller\Order\Reorder\Interceptor))
#17 /magento2/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#18 /magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#19 /magento2/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(99): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#20 /magento2/vendor/magento/framework/Interception/Interceptor.php(135): Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#21 /magento2/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(71): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#22 /magento2/vendor/magento/framework/Interception/Interceptor.php(135): Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#23 /magento2/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#24 /magento2/generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, NULL)
#25 /magento2/vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#26 /magento2/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http->launch()
#27 /magento2/pub/index.php(30): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#28 {main}

[SerhiiMandrykin]

The thing is that in $value = $this->serializer->unserialize($option['option_value']); the option_value is not always a json string