Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Boot 3.1.1 and Java 17 baseline #62

Closed
shakuzen opened this issue Nov 30, 2022 · 11 comments
Closed

Upgrade to Spring Boot 3.1.1 and Java 17 baseline #62

shakuzen opened this issue Nov 30, 2022 · 11 comments

Comments

@shakuzen
Copy link
Member

No description provided.

@shakuzen shakuzen added enhancement New feature or request module: spring labels Nov 30, 2022
@shakuzen shakuzen added this to the 1.6.0 milestone Nov 30, 2022
@klopfdreh
Copy link
Contributor

Just a small question - can you release a version with Spring Boot 2.7.9 (1.5.x) before upgrading to Spring Boot 3.0.0 (1.6.0) as it requires Java 17 and we have only Java 11 available right now?

@shakuzen
Copy link
Member Author

shakuzen commented Mar 9, 2023

Sure, I think we can do that. Please open a separate issue for the upgrade to Boot 2.7.9.

@klopfdreh
Copy link
Contributor

Thanks a lot! 👍

@klopfdreh
Copy link
Contributor

Related Ticket: #67

@kwangyong-park
Copy link

@shakuzen when will Spring Boot 3.0 support be available?

@shakuzen shakuzen changed the title Upgrade to Spring Boot 3.0 Upgrade to Spring Boot 3.1.1 and Java 17 baseline Jul 7, 2023
@shakuzen
Copy link
Member Author

shakuzen commented Jul 7, 2023

@kwangyong-park I've upgraded to Spring Boot 3.1.1 and it is now available in snapshots (1.6.0-SNAPSHOT). Would you be able to test it out for us and let us know if there are any issues with it?

@RomainWilbert
Copy link

Could you push the snapshot into maven repository ?

@shakuzen
Copy link
Member Author

shakuzen commented Jul 7, 2023

It should be in the Spring snapshot repo: https://repo.spring.io/snapshot

@RomainWilbert
Copy link

Seems that version 1.5.2 works with SB3 (3.1.0) & Java 17...

@jonatan-ivanov
Copy link
Member

@RomainWilbert Could you please check again, 1.5.2 should use Boot 2.7.13 (see prometheus-rsocket-proxy-1.5.2.pom) while 1.6.0-SNAPSHOT should use Boot 3.1.1 (see: prometheus-rsocket-proxy-1.6.0-20230707.052345-13.pom).

@RomainWilbert
Copy link

Ok i got this, maybe i made myself not clear : i have tested version 1.5.2 with a Spring Boot 3 project and it works flawlessly (metrics are scraped by rsocket proxy server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants