Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to expand node: column rel.relispartition does not exist LINE 15: AND NOT rel.relispartition #444

Open
shenzj1994 opened this issue Jul 25, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@shenzj1994
Copy link

Describe the bug
When open a 'tables' node in a PostgreSQL database schema. This error occurs.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Connections' on the left navigation panel
  2. Click on 'any database schema'
  3. Scroll down to 'tables' and try expand the node
  4. See error

Expected behavior
It should open the node and show all tables.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10

ADS (please complete the following information):

  • ADS Version: 1.44.1
  • ADS PostgresSQL extension version: 0.4.2
  • PostgreSQL version: PostgreSQL 9.4.26 (Greenplum Database 6.22.2)

Additional context
This issue was fixed in https://github.com/microsoft/sqltoolsservice . Not sure if this extension has any dependency on it.

@shenzj1994
Copy link
Author

It seems only affect certain PostgreSQL variants or versions. I tested on a local docker container with PostgreSQL 15.3 but could not reproduce this issue.

@nasc17 nasc17 added the M4 August 2023, pushed to October 2023 label Jul 27, 2023
@GennadNY GennadNY self-assigned this Aug 3, 2023
@nasc17 nasc17 added enhancement New feature or request and removed M4 August 2023, pushed to October 2023 labels Aug 31, 2023
@DWAK-ATTK
Copy link

Same issue with PostgreSQL version 9.3.13 on Ubuntu server. Using extension version 0.5.0.

@vishwajatania87
Copy link

Same issue with PostgreSQL version 9.5. Using Data Studio on M2 Macbook Pro

@MzeeOjuang
Copy link

Experiencing the same issue, anyone know if this has been resolved?

@shenzj1994
Copy link
Author

Hi @nasc17 , I think this issue is affecting many people and it basically has no workaround. I guess it is more than an 'enhancement' but a real bug... Maybe we can re-prioritize this?

@drw25
Copy link

drw25 commented Oct 27, 2023

I think the problem is with pgtoolsservice, possibly here: https://github.com/microsoft/pgtoolsservice/blob/8aac258e699436a7232129435a5197361d7cc0ba/pgsmo/objects/table/templates/9.1_plus/nodes.sql#L20

According to the Postgres documentation, the relispartition field appeared between versions 9.6 and 10 so this query is likely to fail on versions prior to 10 (the file path implies it'd be used for 9.1+). Compare https://www.postgresql.org/docs/9.6/catalog-pg-class.html and https://www.postgresql.org/docs/10/catalog-pg-class.html

@PacoTuesday
Copy link

Same issue with Postgresql 9.6.24. Using extension v0.6.0 on Windows 10.

@shenzj1994
Copy link
Author

I did some further testing. All the extension versions up to v0.3.1 works fine. Starting with v0.4, this error starts to appear. In my honest opinion, this is a breaking change between these 2 versions. If this is case, why is this not a bug but an 'enhancement'? I am really confused by these labels now...

@peoute
Copy link

peoute commented Mar 21, 2024

We have a posgresql 8.4 install and experienced the same error. v0.3.1 seemed to work ok, but haven't completely tested it. Following this thread for updates.

@baur
Copy link

baur commented Sep 10, 2024

Seme problem:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants