Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: --aof-commit-freq not working #537

Closed
Alirexaa opened this issue Jul 26, 2024 · 2 comments · Fixed by #540
Closed

Bug: --aof-commit-freq not working #537

Alirexaa opened this issue Jul 26, 2024 · 2 comments · Fixed by #540
Assignees

Comments

@Alirexaa
Copy link

Describe the bug

Garnet container with persistent data using bind mount and --aof-commit-freq starts with an error and data does not persist frequently.

error:

01::53::04 fail: StoreWrapper[0] CommitTask exception received, AOF tail address = 376; AOF committed until address = 376;  System.NullReferenceException: Object reference not set to an instance of an object.    at Garnet.server.StoreWrapper.CommitTask(Int32 commitFrequencyMs, ILogger logger, CancellationToken token) in /src/libs/server/StoreWrapper.cs:line 320

Steps to reproduce the bug

Just run following command:

docker run --mount type=bind,source=c:\\tempdata,target=/data  ghcr.io/microsoft/garnet:1.0  "--checkpointdir" "/data/checkpoint" "--recover" "--aof" "--aof-commit-freq" "60000"

Expected behavior

container runs without any errors and data is saved on disk frequently.

Screenshots

No response

Release version

No response

IDE

No response

OS version

No response

Additional context

Container logs:

    _________
   /_||___||_\      Garnet 1.0.15 64 bit; standalone mode
   '. \   / .'      Port: 6379
     '.\ /.'        https://aka.ms/GetGarnet
       '.'

* Ready to accept connections
01::53::04 fail: StoreWrapper[0] CommitTask exception received, AOF tail address = 376; AOF committed until address = 376;  System.NullReferenceException: Object reference not set to an instance of an object.    at Garnet.server.StoreWrapper.CommitTask(Int32 commitFrequencyMs, ILogger logger, CancellationToken token) in /src/libs/server/StoreWrapper.cs:line 320
@badrishc
Copy link
Contributor

badrishc commented Jul 26, 2024

This is a regression from making FastCommit enabled by default. In StoreWrapper.cs line 320,

clusterProvider.IsReplica()

should be

clusterProvider?.IsReplica()

@Alirexaa
Copy link
Author

When is the next version release date including this?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants