Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RepoErrors and error output #19

Open
daviddavis opened this issue Nov 20, 2022 · 0 comments
Open

Improve RepoErrors and error output #19

daviddavis opened this issue Nov 20, 2022 · 0 comments
Labels
enhancement New feature or request repoaudit

Comments

@daviddavis
Copy link
Member

daviddavis commented Nov 20, 2022

Some suggestions:

  • We have this RepoErrors model in the code. I like the idea of the model but we pass it to functions as a parameter and they add to it. I imagine we could instead return it from the functions and create an append method that would append errors to a RepoErrors instance.
  • The RepoErrors model captures all sorts of results including non-error results so it's a bit of misnomer.
  • It's strange that a dist always has to be specified when adding errors to RepoErrors
  • When running the CLI and not using file output, a bunch of information just gets spewed out. A lot of the information is unnecessary such as successes
@daviddavis daviddavis added enhancement New feature or request repoaudit labels Nov 20, 2022
@daviddavis daviddavis changed the title Extend RepoErrors model Improve RepoErrors and error output Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request repoaudit
Projects
None yet
Development

No branches or pull requests

2 participants
@daviddavis and others