Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization to WingetCreateCore to provide better error messages from library functions #101

Closed
palenshus opened this issue Jun 30, 2021 · 0 comments · Fixed by #138
Closed

Add localization to WingetCreateCore to provide better error messages from library functions #101

palenshus opened this issue Jun 30, 2021 · 0 comments · Fixed by #138
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed Size-XS

Comments

@palenshus
Copy link
Contributor

Description of the new feature/enhancement

Since we don't have localization in the core library, we have to bend over backwards to provide helpful errors to the user from errors in the library function. The library functions need to somehow convey their error to the calling function so it can display localized errors instead of just logging it itself, or throwing a localized exception.

Proposed technical implementation details (optional)

Add localization to the core library, and simplify error handling to log some error messages directly from the library.
@palenshus palenshus added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 30, 2021
@ghost ghost added the Needs-Triage label Jun 30, 2021
@ryfu-msft ryfu-msft mentioned this issue Aug 13, 2021
Closed
@ghost ghost added In-PR and removed In-PR labels Aug 13, 2021
@ryfu-msft ryfu-msft mentioned this issue Aug 17, 2021
Merged
@ghost ghost added the In-PR label Aug 17, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed Size-XS
Projects
None yet
Milestone
No milestone
3 participants
@palenshus @denelon @ryfu-msft