Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine EQ and XFader to Mixer page in Preferencs #9401

Closed
mixxxbot opened this issue Aug 23, 2022 · 3 comments · Fixed by #11272
Closed

Combine EQ and XFader to Mixer page in Preferencs #9401

mixxxbot opened this issue Aug 23, 2022 · 3 comments · Fixed by #11272

Comments

@mixxxbot
Copy link
Collaborator

Reported by: kazakore
Date: 2018-08-09T09:54:01Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1786211
Tags: preferences


(Wishlist/feature change)

I feel it may help people find certain settings if the preferences for everything which could be considered part of the Mixer were on a single page in Preferences. This has come to my attention due to a user struggling to find the Quick Effects options after losing the control knob. [1]

I believe currently this would mean a merge of the Equalisers and the Crossfader page into a single page. Although this will increase the size of the page it would still be smaller than some others (eg Sound Hardware) and the Preferences is already vertically scrollable so this should not be a huge issue IMO.

Assumedly a new Preference page will be added at some point for Effects (managing saved FXChains and visible 3rd party effects if LV2 support comes in) so whether Quick Effects belongs here on in the Mixer section may be worth a discussion. Or maybe the Effects stuff with be done through a sub pane/window of its own rather than Preferences.... I don't know but may be worth thinking about in connection to this.

[1] https://www.mixxx.org/forums/viewtopic.php?f=3&t=12032

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2018-08-09T23:39:07Z


I like the idea of a combined Mixer pane. It definitely simplifies finding certain Mixxx preferences if they grouped in pref panes like they are in skins. We already have Waveforms, Decks, Effects and Library, so it makes sense to combine EQ, QuickEffect & Crossfader in a Mixer pane.

btw 2.2-alpha already has the effects and LV2 settings pane in Preferences where you can choose which effects (built-in or LV2) and which parameters are exposed in effect units:
http://downloads.mixxx.org/builds/master/release/
(2.2 = current master)

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-21T00:19:21Z


+1 to this.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2018-09-21T00:35:02Z


I am afraid this may not be so easy because the code for DlgPrefEQ is messy. I did work in #1705 to start cleaning it up, but there is still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants