Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svgdraw creates wrong item #149

Closed
ThomasWaldmann opened this issue Jan 9, 2012 · 7 comments
Closed

svgdraw creates wrong item #149

ThomasWaldmann opened this issue Jan 9, 2012 · 7 comments
Labels
bug Something isn't working drawing related to any drawing tool we use prio3 normal prio
Milestone

Comments

@ThomasWaldmann
Copy link
Member

Original report by Reimar Bauer (Bitbucket: ReimarBauer, GitHub: ReimarBauer).


by some change svgdraw (may be this counts for all drawing items)
now saves to item name "undefined" and not to the given one.

@ThomasWaldmann
Copy link
Member Author

Original comment by Sam Toyer (Bitbucket: qxcv, GitHub: qxcv).


I've figured out the problem here - env/lib/python2.7/site-packages/xstatic/pkg/svgedit_moin/data/editor/extensions/ext-server_moinsave.js has a line:

var name = qstr.substr(9).split('/+get/')[1];

Which should be:

var name = qstr.substr(9).split('/%2Bget/')[1];

As Flask's url_for quotes the URL so it can be included in the form.

Presumably it was broken by an upstream change in Flask or Werkzeug.

Also: the "Unable to load from URL:\nundefined" error message is unrelated, undefined refers to the fact that jQuery did not return an error message when it got a 404 on the /+get/<item name> page. See line 4813 of svg-editor.js.

@ThomasWaldmann
Copy link
Member Author

Original comment by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).


can you check whether this bug is introduced by werkzeug 0.8.2 and does not happen with 0.8.1?

@ThomasWaldmann
Copy link
Member Author

Original comment by Sam Toyer (Bitbucket: qxcv, GitHub: qxcv).


Ah, I see your issue at pallets/werkzeug#146

Installed Werkzeug 0.8.1 and the issue no longer happened. I shall amend my original fix to:

var name = qstr.substr(9).split(/\/(?:\+|%2B)get\//)[1];

This should handle both situations until Werkzeug >0.8.2 is released.

@ThomasWaldmann
Copy link
Member Author

Original comment by xiaq (Bitbucket: xiaq, GitHub: xiaq).


As of today, this bug is still present...

@ThomasWaldmann
Copy link
Member Author

Original comment by Reimar Bauer (Bitbucket: ReimarBauer, GitHub: ReimarBauer).


2012-07-15 nothing changed yet

@ThomasWaldmann
Copy link
Member Author

Original comment by Reimar Bauer (Bitbucket: ReimarBauer, GitHub: ReimarBauer).


The workaround of Sam Toyer was added to the save extension,

https://bitbucket.org/ReimarBauer/xstatic-svg-edit-moin/changeset/fe5ca63c6adf795d85461da3305153b0

@ThomasWaldmann ThomasWaldmann added prio3 normal prio bug Something isn't working 2.0.0a0 and removed 2.0.0a0 labels Aug 26, 2018
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0a0 milestone Aug 26, 2018
@ThomasWaldmann ThomasWaldmann added drawing related to any drawing tool we use and removed scripts labels Aug 26, 2018
@ThomasWaldmann ThomasWaldmann modified the milestones: 2.0.0a0, 2.0.0a1 Aug 27, 2018
@RogerHaase
Copy link
Member

closing as dup of #355

svgdraw is very broken, needs newer version of https://github.com/SVG-Edit/svgedit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working drawing related to any drawing tool we use prio3 normal prio
Projects
None yet
Development

No branches or pull requests

2 participants