Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonBlockingClient.send will create a Link for each unique topic, can't release them #14

Open
leachbj opened this issue Jul 9, 2015 · 2 comments
Labels

Comments

@leachbj
Copy link
Contributor

leachbj commented Jul 9, 2015

Each call to a send() method with a unique topic will result in a new Link back to the broker however there is no automatic cleanup for old/unused Link's nor any api to trigger. This results in a build up of Sender instances on the connection.

@dnwe dnwe added the bug label Nov 18, 2015
@dnwe
Copy link
Contributor

dnwe commented Nov 18, 2015

@leachbj are you happy that the SendOptions.retainLink from pull #18 sufficiently addresses this issue? Or do you think we should also add automatic cleanup of stale links?

@leachbj
Copy link
Contributor Author

leachbj commented Nov 18, 2015

The manual mechanism should be fine for most cases. It probably makes sense to have some clean up mechanism but not sure what the exact API/mechanism should be. So just something to think about for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants