Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] persistent=true open=false visible after component update. #8963

Closed
1 task done
chrumck opened this issue Nov 2, 2017 · 2 comments
Closed
1 task done

[Drawer] persistent=true open=false visible after component update. #8963

chrumck opened this issue Nov 2, 2017 · 2 comments
Assignees
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!

Comments

@chrumck
Copy link

chrumck commented Nov 2, 2017

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Drawer should not show up on re-render

Current Behavior

If the Drawer component is re-rendered, the nested Paper component loses its transform style setting and the drawer is shown despite open=false

Steps to Reproduce (for bugs)

codesandbox

Context

I believe this has something to do with the code removed from the Slide component with this update

Your Environment

Tech Version
Material-UI 1.0.0-beta.19
React v16
browser Chrome, Firefox
etc
@oliviertassinari oliviertassinari self-assigned this Nov 2, 2017
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! labels Nov 2, 2017
@oliviertassinari
Copy link
Member

Thanks for raising the issue!

@freb
Copy link

freb commented Feb 4, 2018

Not sure if you want me to file a separate issue, but I just ran into something very closely related to this. When the drawer is closed, if you add content to the drawer, changing its height, the content will spill onto the screen. It's most noticeable on anchor="bottom", but, also happens on side anchors (but you must add much more content before its manifests.

Here is a demo: https://codesandbox.io/s/vqvzk2zv2y

You can see the Sandbox is using beta.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants