Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Touch on analog clock doesn't feel responsive enough #9312

Closed
joserodolfofreitas opened this issue Jun 13, 2023 · 4 comments · Fixed by #14305
Closed

[pickers] Touch on analog clock doesn't feel responsive enough #9312

joserodolfofreitas opened this issue Jun 13, 2023 · 4 comments · Fixed by #14305
Assignees
@arthurbalduini
Labels
component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Jun 13, 2023 •
edited
Loading

Extracted from #8964 (comment)

Summary

On https://mui.com/x/react-date-pickers/time-picker/#basic-usage the clock only responds on "touch move" and "touch end". It should respond on "touch start" too, this is wrong:

Screen.Recording.2023-05-12.at.15.18.17.mov

You can compare the UX on a native Android time picker, this feels good:

Screen.Recording.2023-05-12.at.15.51.56.mov

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time

It also feels correct in http://react-toolbox.io/#/components/time_picker too.
@joserodolfofreitas joserodolfofreitas added component: pickers This is the name of the generic UI component, not the React module! component: DateTimePicker The React component. component: TimePicker The React component. design: ux enhancement This is not a bug, nor a new feature labels Jun 13, 2023
@joserodolfofreitas joserodolfofreitas changed the title [pickers] Touch on Analog clock feels not responsive enough [pickers] Touch on Analog clock doesn't feel responsive enough Jun 13, 2023
@joserodolfofreitas joserodolfofreitas changed the title [pickers] Touch on Analog clock doesn't feel responsive enough [pickers] Touch on analog clock doesn't feel responsive enough Jun 13, 2023
@joserodolfofreitas joserodolfofreitas added support: unknown Support request type not verified yet. Head to https://tools-public.mui.com/prod/pages/jyhs86t and removed support: unknown Support request type not verified yet. Head to https://tools-public.mui.com/prod/pages/jyhs86t labels Jun 13, 2023
@rajpatelbot
Copy link

Hey @joserodolfofreitas, It's looks interesting to me, I am happy to go with it.

Thank you...

@joserodolfofreitas
Copy link
Member Author

@rajpatelbot, please feel free to try implementing it. You can open a PR for review at any time.

@rajpatelbot
Copy link

Sure. Thank you...

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
@arthurbalduini arthurbalduini self-assigned this Aug 22, 2024
@arthurbalduini arthurbalduini mentioned this issue Aug 23, 2024
Merged
@github-actions GitHub Actions
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@joserodolfofreitas: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurbalduini arthurbalduini

Labels
component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pickers] Add onTouchStart handler for TimeClock arthurbalduini/mui-x
4 participants
@joserodolfofreitas @oliviertassinari @arthurbalduini @rajpatelbot