-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input text not visible in cases due to color:inherit #469
Comments
color: inherit; /* 1 */ should be removed. |
Absolutely, I dont know who decided this value for color. If that color need to be inherited, then background-color cant stay static as #FFF in original or changed one by developer |
@clottes @CemDemirkartal agree that inherit should be removed - https://github.com/necolas/normalize.css/blob/master/normalize.css#L256 /cc @necolas will PR be accepted? |
This was fixed by #502. |
Thanks, @cvrebert, for spotting this! |
The color:inherit will obviously cause problems if font color is set to something close to white in any section of html. (Say a header section, etc with a dark background). Since the font-color becomes inherited, but the background remains default in input elements, it won't look correct or make any sense. It should NOT be assumed that the user's text in a section of html will not be white or a color close to what happens to be background color of input elements.
button,
input,
optgroup,
select,
textarea {
color: inherit; /* 1 /
font: inherit; / 2 /
margin: 0; / 3 */
}
The text was updated successfully, but these errors were encountered: