Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input text not visible in cases due to color:inherit #469

Closed
clottes opened this issue Aug 24, 2015 · 5 comments
Closed

Input text not visible in cases due to color:inherit #469

clottes opened this issue Aug 24, 2015 · 5 comments

Comments

@clottes
Copy link

clottes commented Aug 24, 2015

The color:inherit will obviously cause problems if font color is set to something close to white in any section of html. (Say a header section, etc with a dark background). Since the font-color becomes inherited, but the background remains default in input elements, it won't look correct or make any sense. It should NOT be assumed that the user's text in a section of html will not be white or a color close to what happens to be background color of input elements.

button,
input,
optgroup,
select,
textarea {
color: inherit; /* 1 /
font: inherit; /
2 /
margin: 0; /
3 */
}

@clottes
Copy link
Author

clottes commented Aug 24, 2015

color: inherit; /* 1 */ should be removed.

@CemDemirkartal
Copy link

Absolutely, I dont know who decided this value for color. If that color need to be inherited, then background-color cant stay static as #FFF in original or changed one by developer

@voronianski
Copy link

@clottes @CemDemirkartal agree that inherit should be removed - https://github.com/necolas/normalize.css/blob/master/normalize.css#L256 /cc @necolas will PR be accepted?

@cvrebert
Copy link

This was fixed by #502.

@jonathantneal
Copy link
Contributor

Thanks, @cvrebert, for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants