Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TriState #1456

Open
Technici4n opened this issue Aug 15, 2024 · 3 comments
Open

Remove TriState #1456

Technici4n opened this issue Aug 15, 2024 · 3 comments
Labels
1.21.2 Targeted at Minecraft 1.21.2 breaking change Breaks binary compatibility cleanup Change that isn't an enhancement or a bug fix

Comments

@Technici4n
Copy link
Member

Vanilla has it in the latest snapshot.

@Technici4n Technici4n added cleanup Change that isn't an enhancement or a bug fix breaking change Breaks binary compatibility 1.21.2 Targeted at Minecraft 1.21.2 labels Aug 15, 2024
@TelepathicGrunt
Copy link
Contributor

Woah woah woah! Don’t be quick to yeet our implementation! You won’t know if Mojang will one day mutate TriState into a horrible monstrosity like MsoTriState lmao

@tmvkrpxl0
Copy link
Contributor

Ok I looked it up what it is and I'm in shambles

@KnightMiner
Copy link
Contributor

Is there any real advantage to using the same enum as vanilla? I feel like such a thing is simple enough and unlikely enough to be transferred between enum types that its not a huge deal if its duplicated. Though I suppose the name clash would be problematic for imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.2 Targeted at Minecraft 1.21.2 breaking change Breaks binary compatibility cleanup Change that isn't an enhancement or a bug fix
Projects
None yet
Development

No branches or pull requests

4 participants