Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'Invariant Violation fix' to npm library #38

Open
wongcoder opened this issue May 9, 2019 · 8 comments
Open

Merge 'Invariant Violation fix' to npm library #38

wongcoder opened this issue May 9, 2019 · 8 comments

Comments

@wongcoder
Copy link

Was working on React Native 0.59, imported your library, and realized that there was an invariant violation in ColorWheel.js.

It seems to be fixed on a later fix to master, but for some odd reason, NPM didn't pick up your changes.

This is a fantastic library, and I can't wait for the update.

@nsmet
Copy link

nsmet commented May 10, 2019

I don't think it was pushed to NPM, 0.1.7 is the latest tag and the update came after that. Facing the same issue, would love an update.

@LapX
Copy link

LapX commented May 12, 2019

Yup, same problem here. I would also love an update.

@wongcoder
Copy link
Author

Yeah, I basically just manually implemented the changes on my local machine, just gotta wait for the developers.

@irajwani
Copy link

@wongcoder What changes did you make?

@netbeast could you please provide update your package?

Thanks.

@LapX
Copy link

LapX commented Aug 14, 2019

@irajwani look at the code in the master branch and do the same modification. It worked for me. You must know where it crashes by looking at the error you got.

@irajwani
Copy link

Thank you @LapX, it worked! Fantastic library.

@pastyman
Copy link

pastyman commented Oct 8, 2019

update your package.json,

replace:

"react-native-color-wheel": "^0.1.7",

with:

"react-native-color-wheel": "https://github.com/netbeast/react-native-color-wheel.git",

That fixed it for me!

@wongcoder
Copy link
Author

Nice automated fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants