From 83b7b7d311123fe5552e5df4ef9d1cca490ae393 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 20 Feb 2024 20:35:58 +0100
Subject: [PATCH 1/4] fix(FilePicker): Adjust DAV composable to be able to work
 on public `webdav` endpoint

Co-authored-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 lib/components/FilePicker/FilePicker.vue | 14 +++--
 lib/composables/dav.spec.ts              | 31 ++++++++--
 lib/composables/dav.ts                   | 77 +++++++++++++++++++-----
 lib/composables/isPublic.ts              | 15 +++++
 4 files changed, 112 insertions(+), 25 deletions(-)
 create mode 100644 lib/composables/isPublic.ts

diff --git a/lib/components/FilePicker/FilePicker.vue b/lib/components/FilePicker/FilePicker.vue
index 5d1a3d2a..0a5ab870 100644
--- a/lib/components/FilePicker/FilePicker.vue
+++ b/lib/components/FilePicker/FilePicker.vue
@@ -61,8 +61,9 @@ import { computed, onMounted, ref, toRef } from 'vue'
 import { showError } from '../../toast'
 import { useDAVFiles } from '../../composables/dav'
 import { useMimeFilter } from '../../composables/mime'
-import { t } from '../../utils/l10n'
 import { useFilesSettings } from '../../composables/filesSettings'
+import { useIsPublic } from '../../composables/isPublic'
+import { t } from '../../utils/l10n'
 
 const props = withDefaults(defineProps<{
 	/** Buttons to be displayed */
@@ -120,6 +121,11 @@ const emit = defineEmits<{
 	(e: 'close', v?: Node[]): void
 }>()
 
+/**
+ * Whether we are on a public endpoint (e.g. public share)
+ */
+const { isPublic } = useIsPublic()
+
 const isOpen = ref(true)
 
 /**
@@ -221,7 +227,7 @@ const filterString = ref('')
 
 const { isSupportedMimeType } = useMimeFilter(toRef(props, 'mimetypeFilter')) // vue 3.3 will allow cleaner syntax of toRef(() => props.mimetypeFilter)
 
-const { files, isLoading, loadFiles, getFile, client } = useDAVFiles(currentView, currentPath)
+const { files, isLoading, loadFiles, getFile, createDirectory } = useDAVFiles(currentView, currentPath, isPublic)
 
 onMounted(() => loadFiles())
 
@@ -271,9 +277,7 @@ const noFilesDescription = computed(() => {
  */
 const onCreateFolder = async (name: string) => {
 	try {
-		await client.createDirectory(join(davRootPath, currentPath.value, name))
-		// reload file list
-		await loadFiles()
+		await createDirectory(name)
 		// emit event bus to force files app to reload that file if needed
 		emitOnEventBus('files:node:created', files.value.filter((file) => file.basename === name)[0])
 	} catch (error) {
diff --git a/lib/composables/dav.spec.ts b/lib/composables/dav.spec.ts
index b8ebd1b0..2f755b8d 100644
--- a/lib/composables/dav.spec.ts
+++ b/lib/composables/dav.spec.ts
@@ -28,6 +28,7 @@ import { useDAVFiles } from './dav'
 const nextcloudFiles = vi.hoisted(() => ({
 	davGetClient: vi.fn(),
 	davRootPath: '/root/uid',
+	davRemoteURL: 'https://localhost/remote.php/dav',
 	davResultToNode: vi.fn(),
 	davGetDefaultPropfind: vi.fn(),
 	davGetRecentSearch: (time: number) => `recent ${time}`,
@@ -44,9 +45,9 @@ const waitLoaded = (vue: ReturnType<typeof shallowMount>) => new Promise((resolv
 })
 
 const TestComponent = defineComponent({
-	props: ['currentView', 'currentPath'],
+	props: ['currentView', 'currentPath', 'isPublic'],
 	setup(props) {
-		const dav = useDAVFiles(toRef(props, 'currentView'), toRef(props, 'currentPath'))
+		const dav = useDAVFiles(toRef(props, 'currentView'), toRef(props, 'currentPath'), toRef(props, 'isPublic'))
 		return {
 			...dav,
 		}
@@ -67,6 +68,7 @@ describe('dav composable', () => {
 			propsData: {
 				currentView: 'files',
 				currentPath: '/',
+				isPublic: false,
 			},
 		})
 		// Loading is set to true
@@ -92,6 +94,7 @@ describe('dav composable', () => {
 			propsData: {
 				currentView: 'files',
 				currentPath: '/',
+				isPublic: false,
 			},
 		})
 
@@ -111,6 +114,7 @@ describe('dav composable', () => {
 			propsData: {
 				currentView: 'files',
 				currentPath: '/',
+				isPublic: false,
 			},
 		})
 
@@ -138,6 +142,7 @@ describe('dav composable', () => {
 			propsData: {
 				currentView: 'files',
 				currentPath: '/',
+				isPublic: false,
 			},
 		})
 
@@ -164,12 +169,28 @@ describe('dav composable', () => {
 		nextcloudFiles.davGetClient.mockImplementationOnce(() => client)
 		nextcloudFiles.davResultToNode.mockImplementationOnce((v) => v)
 
-		const { getFile } = useDAVFiles(ref('files'), ref('/'))
+		const { getFile } = useDAVFiles(ref('files'), ref('/'), ref(false))
 
 		const node = await getFile('/some/path')
 		expect(node).toEqual({ path: `${nextcloudFiles.davRootPath}/some/path` })
 		expect(client.stat).toBeCalledWith(`${nextcloudFiles.davRootPath}/some/path`, { details: true })
-		expect(nextcloudFiles.davResultToNode).toBeCalledWith({ path: `${nextcloudFiles.davRootPath}/some/path` })
+		expect(nextcloudFiles.davResultToNode).toBeCalledWith({ path: `${nextcloudFiles.davRootPath}/some/path` }, nextcloudFiles.davRootPath, nextcloudFiles.davRemoteURL)
+	})
+
+	it('createDirectory works', async () => {
+		const client = {
+			stat: vi.fn((v) => ({ data: { path: v } })),
+			createDirectory: vi.fn(() => {}),
+		}
+		nextcloudFiles.davGetClient.mockImplementationOnce(() => client)
+		nextcloudFiles.davResultToNode.mockImplementationOnce((v) => v)
+
+		const { createDirectory } = useDAVFiles(ref('files'), ref('/foo/'), ref(false))
+
+		const node = await createDirectory('my-name')
+		expect(node).toEqual({ path: `${nextcloudFiles.davRootPath}/foo/my-name` })
+		expect(client.stat).toBeCalledWith(`${nextcloudFiles.davRootPath}/foo/my-name`, { details: true })
+		expect(client.createDirectory).toBeCalledWith(`${nextcloudFiles.davRootPath}/foo/my-name`)
 	})
 
 	it('loadFiles work', async () => {
@@ -183,7 +204,7 @@ describe('dav composable', () => {
 
 		const view = ref<'files' | 'recent' | 'favorites'>('files')
 		const path = ref('/')
-		const { loadFiles, isLoading } = useDAVFiles(view, path)
+		const { loadFiles, isLoading } = useDAVFiles(view, path, ref(false))
 
 		expect(isLoading.value).toBe(true)
 		await loadFiles()
diff --git a/lib/composables/dav.ts b/lib/composables/dav.ts
index 43877966..55b2d4d5 100644
--- a/lib/composables/dav.ts
+++ b/lib/composables/dav.ts
@@ -19,12 +19,14 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
  */
-import type { Node } from '@nextcloud/files'
+import type { Folder, Node } from '@nextcloud/files'
 import type { ComputedRef, Ref } from 'vue'
-import type { FileStat, ResponseDataDetailed, SearchResult, WebDAVClient } from 'webdav'
+import type { FileStat, ResponseDataDetailed, SearchResult } from 'webdav'
 
-import { davGetClient, davGetDefaultPropfind, davGetRecentSearch, davResultToNode, davRootPath, getFavoriteNodes } from '@nextcloud/files'
-import { onMounted, ref, watch } from 'vue'
+import { davGetClient, davGetDefaultPropfind, davGetRecentSearch, davRemoteURL, davResultToNode, davRootPath, getFavoriteNodes } from '@nextcloud/files'
+import { generateRemoteUrl } from '@nextcloud/router'
+import { join } from 'path'
+import { computed, onMounted, ref, watch } from 'vue'
 
 /**
  * Handle file loading using WebDAV
@@ -35,11 +37,35 @@ import { onMounted, ref, watch } from 'vue'
 export const useDAVFiles = function(
 	currentView: Ref<'files'|'recent'|'favorites'> | ComputedRef<'files'|'recent'|'favorites'>,
 	currentPath: Ref<string> | ComputedRef<string>,
-): { isLoading: Ref<boolean>, client: WebDAVClient, files: Ref<Node[]>, loadFiles: () => Promise<void>, getFile: (path: string) => Promise<Node> } {
+	isPublicEndpoint: Ref<boolean> | ComputedRef<boolean>
+): { isLoading: Ref<boolean>, createDirectory: (name: string) => Promise<Folder>, files: Ref<Node[]>, loadFiles: () => Promise<void>, getFile: (path: string) => Promise<Node> } {
+
+	const defaultRootPath = computed(() => isPublicEndpoint.value ? '/' : davRootPath)
+
+	const defaultRemoteUrl = computed(() => {
+		if (isPublicEndpoint.value) {
+			return generateRemoteUrl('webdav').replace('/remote.php', '/public.php')
+		}
+		return davRemoteURL
+	})
+
 	/**
 	 * The WebDAV client
 	 */
-	const client = davGetClient()
+	const client = computed(() => {
+		if (isPublicEndpoint.value) {
+			const token = (document.getElementById('sharingToken')! as HTMLInputElement).value
+			const authorization = btoa(`${token}:null`)
+
+			return davGetClient(defaultRemoteUrl.value, {
+				Authorization: `Basic ${authorization}`,
+			})
+		}
+
+		return davGetClient()
+	})
+
+	const resultToNode = (result: FileStat) => davResultToNode(result, defaultRootPath.value, defaultRemoteUrl.value)
 
 	/**
 	 * All files in current view and path
@@ -51,17 +77,33 @@ export const useDAVFiles = function(
 	 */
 	const isLoading = ref(true)
 
+	/**
+	 * Create a new directory in the current path
+	 * @param name Name of the new directory
+	 * @return The created directory
+	 */
+	async function createDirectory(name: string): Promise<Folder> {
+		const path = join(currentPath.value, name)
+
+		await client.value.createDirectory(join(defaultRootPath.value, path))
+		const directory = await getFile(path) as Folder
+		files.value.push(directory)
+		return directory
+	}
+
 	/**
 	 * Get information for one file
 	 *
 	 * @param path The path of the file or folder
 	 * @param rootPath DAV root path, defaults to '/files/USERID'
 	 */
-	async function getFile(path: string, rootPath = davRootPath) {
-		const result = await client.stat(`${rootPath}${path}`, {
+	async function getFile(path: string, rootPath: string|undefined = undefined) {
+		rootPath = rootPath ?? defaultRootPath.value
+
+		const { data } = await client.value.stat(`${rootPath}${path}`, {
 			details: true,
 		}) as ResponseDataDetailed<FileStat>
-		return davResultToNode(result.data)
+		return resultToNode(data)
 	}
 
 	/**
@@ -71,21 +113,26 @@ export const useDAVFiles = function(
 		isLoading.value = true
 
 		if (currentView.value === 'favorites') {
-			files.value = await getFavoriteNodes(client, currentPath.value)
+			files.value = await getFavoriteNodes(client.value, currentPath.value, defaultRootPath.value)
 		} else if (currentView.value === 'recent') {
 			// unix timestamp in seconds, two weeks ago
 			const lastTwoWeek = Math.round(Date.now() / 1000) - (60 * 60 * 24 * 14)
-			const { data } = await client.search('/', {
+			const { data } = await client.value.search('/', {
 				details: true,
 				data: davGetRecentSearch(lastTwoWeek),
 			}) as ResponseDataDetailed<SearchResult>
-			files.value = data.results.map((r) => davResultToNode(r))
+			files.value = data.results.map(resultToNode)
 		} else {
-			const results = await client.getDirectoryContents(`${davRootPath}${currentPath.value}`, {
+			const results = await client.value.getDirectoryContents(`${defaultRootPath.value}${currentPath.value}`, {
 				details: true,
 				data: davGetDefaultPropfind(),
 			}) as ResponseDataDetailed<FileStat[]>
-			files.value = results.data.map((r) => davResultToNode(r))
+			files.value = results.data.map(resultToNode)
+
+			// Hack for the public endpoint which always returns folder itself
+			if (isPublicEndpoint.value) {
+				files.value = files.value.filter((file) => file.path !== currentPath.value)
+			}
 		}
 
 		isLoading.value = false
@@ -106,6 +153,6 @@ export const useDAVFiles = function(
 		files,
 		loadFiles: loadDAVFiles,
 		getFile,
-		client,
+		createDirectory,
 	}
 }
diff --git a/lib/composables/isPublic.ts b/lib/composables/isPublic.ts
new file mode 100644
index 00000000..c80dab17
--- /dev/null
+++ b/lib/composables/isPublic.ts
@@ -0,0 +1,15 @@
+import { onBeforeMount, ref } from "vue"
+
+/**
+ * Check whether the component is mounted in a public share
+ */
+export const useIsPublic = () => {
+	const checkIsPublic = () => (document.getElementById('isPublic') as HTMLInputElement|null)?.value === '1'
+	
+	const isPublic = ref(true)
+	onBeforeMount(() => { isPublic.value = checkIsPublic() })
+
+	return {
+		isPublic,
+	}
+}

From d3c4e26c05ad572b970ad04a1dc4aaa82f46c0d4 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 20 Feb 2024 20:37:35 +0100
Subject: [PATCH 2/4] fix(FilePicker): Only load files views and files config
 on internal routes

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 lib/components/FilePicker/FilePicker.vue      |  5 +-
 .../FilePicker/FilePickerNavigation.vue       | 73 ++++++++---------
 lib/composables/filesSettings.spec.ts         | 22 ++++--
 lib/composables/filesSettings.ts              | 67 +++++++++++-----
 lib/composables/views.spec.ts                 | 50 ++++++++++++
 lib/composables/views.ts                      | 79 +++++++++++++++++++
 package-lock.json                             |  6 ++
 package.json                                  |  1 +
 8 files changed, 231 insertions(+), 72 deletions(-)
 create mode 100644 lib/composables/views.spec.ts
 create mode 100644 lib/composables/views.ts

diff --git a/lib/components/FilePicker/FilePicker.vue b/lib/components/FilePicker/FilePicker.vue
index 0a5ab870..8d36cbf2 100644
--- a/lib/components/FilePicker/FilePicker.vue
+++ b/lib/components/FilePicker/FilePicker.vue
@@ -45,8 +45,9 @@
 </template>
 
 <script setup lang="ts">
-import type { IFilePickerButton, IFilePickerButtonFactory, IFilePickerFilter } from '../types'
 import type { Node } from '@nextcloud/files'
+import type { IFilePickerButton, IFilePickerButtonFactory, IFilePickerFilter } from '../types.ts'
+import type { IFilesViewId } from '../../composables/views.ts'
 
 import IconFile from 'vue-material-design-icons/File.vue'
 import FileList from './FileList.vue'
@@ -176,7 +177,7 @@ const handleButtonClick = async (callback: IFilePickerButton['callback']) => {
 /**
  * Name of the currently active view
  */
-const currentView = ref<'files' | 'favorites' | 'recent'>('files')
+const currentView = ref<IFilesViewId>('files')
 
 /**
  * Headline to be used on the current view
diff --git a/lib/components/FilePicker/FilePickerNavigation.vue b/lib/components/FilePicker/FilePickerNavigation.vue
index 9de38654..f3256e7e 100644
--- a/lib/components/FilePicker/FilePickerNavigation.vue
+++ b/lib/components/FilePicker/FilePickerNavigation.vue
@@ -12,55 +12,42 @@
 				<IconClose :size="16" />
 			</template>
 		</NcTextField>
-		<!-- On non collapsed dialogs show the tablist, otherwise a dropdown is shown -->
-		<ul v-if="!isCollapsed"
-			class="file-picker__side">
-			<li v-for="view in allViews" :key="view.id">
-				<NcButton :type="currentView === view.id ? 'primary' : 'tertiary'"
-					:wide="true"
-					@click="$emit('update:currentView', view.id)">
-					<template #icon>
-						<component :is="view.icon" :size="20" />
-					</template>
-					{{ view.label }}
-				</NcButton>
-			</li>
-		</ul>
-		<NcSelect v-else
-			:aria-label="t('Current view selector')"
-			:clearable="false"
-			:searchable="false"
-			:options="allViews"
-			:value="currentViewObject"
-			@input="v => emit('update:currentView', v.id)" />
+		<template v-if="availableViews.length > 1">
+			<!-- On non collapsed dialogs show the tablist, otherwise a dropdown is shown -->
+			<ul v-if="!isCollapsed"
+				class="file-picker__side">
+				<li v-for="view in availableViews" :key="view.id">
+					<NcButton :type="currentView === view.id ? 'primary' : 'tertiary'"
+						:wide="true"
+						@click="$emit('update:currentView', view.id)">
+						<template #icon>
+							<NcIconSvgWrapper :path="view.icon" :size="20" />
+						</template>
+						{{ view.label }}
+					</NcButton>
+				</li>
+			</ul>
+			<NcSelect v-else
+				:aria-label="t('Current view selector')"
+				:clearable="false"
+				:searchable="false"
+				:options="availableViews"
+				:value="currentViewObject"
+				@input="(v) => emit('update:currentView', v.id)" />
+		</template>
 	</Fragment>
 </template>
 
 <script setup lang="ts">
-import IconFolder from 'vue-material-design-icons/Folder.vue'
-import IconClock from 'vue-material-design-icons/Clock.vue'
 import IconClose from 'vue-material-design-icons/Close.vue'
 import IconMagnify from 'vue-material-design-icons/Magnify.vue'
-import IconStar from 'vue-material-design-icons/Star.vue'
 
-import { NcButton, NcSelect, NcTextField } from '@nextcloud/vue'
-import { t } from '../../utils/l10n'
-import { computed } from 'vue'
+import { getCurrentUser } from '@nextcloud/auth'
+import { NcButton, NcIconSvgWrapper, NcSelect, NcTextField } from '@nextcloud/vue'
+import { computed, ref } from 'vue'
 import { Fragment } from 'vue-frag'
-
-const allViews = [{
-	id: 'files',
-	label: t('All files'),
-	icon: IconFolder,
-}, {
-	id: 'recent',
-	label: t('Recent'),
-	icon: IconClock,
-}, {
-	id: 'favorites',
-	label: t('Favorites'),
-	icon: IconStar,
-}]
+import { t } from '../../utils/l10n'
+import { useViews } from '../../composables/views'
 
 const props = defineProps<{
 	currentView: 'files' | 'recent' | 'favorites',
@@ -74,10 +61,12 @@ interface INavigationEvents {
 }
 const emit = defineEmits<INavigationEvents>()
 
+const { availableViews } = useViews(ref(getCurrentUser() === null))
+
 /**
  * The currently active view object
  */
-const currentViewObject = computed(() => allViews.filter(v => v.id === props.currentView)[0])
+const currentViewObject = computed(() => availableViews.filter(v => v.id === props.currentView)[0] ?? availableViews[0])
 
 /**
  * Propagate current filter value to paren
diff --git a/lib/composables/filesSettings.spec.ts b/lib/composables/filesSettings.spec.ts
index 07cb9461..0231bfa7 100644
--- a/lib/composables/filesSettings.spec.ts
+++ b/lib/composables/filesSettings.spec.ts
@@ -22,13 +22,16 @@
 
 import { describe, it, expect, vi, afterEach, beforeAll, afterAll } from 'vitest'
 import { shallowMount } from '@vue/test-utils'
-import { defineComponent } from 'vue'
+import { defineComponent, nextTick } from 'vue'
 import { useFilesSettings } from './filesSettings'
 
 const axios = vi.hoisted(() => ({
 	get: vi.fn(),
 }))
+const isPublic = vi.hoisted(() => ({ value: false }))
+
 vi.mock('@nextcloud/axios', () => ({ default: axios }))
+vi.mock('./isPublic', () => ({ useIsPublic: () => ({ isPublic }) }))
 
 const TestComponent = defineComponent({
 	setup() {
@@ -49,8 +52,10 @@ describe('files app settings composable', () => {
 		axios.get.mockImplementation(() => {
 			return new Promise(() => {})
 		})
-		const vue = await shallowMount(TestComponent)
-		expect(vue.vm.showHiddenFiles).toBe(false)
+		const vue = shallowMount(TestComponent)
+		await nextTick()
+
+		expect(vue.vm.showHiddenFiles).toBe(true)
 		expect(vue.vm.sortFavoritesFirst).toBe(true)
 		expect(vue.vm.cropImagePreviews).toBe(true)
 		expect(axios.get).toBeCalled()
@@ -58,11 +63,14 @@ describe('files app settings composable', () => {
 
 	it('is reactive when loading values', async () => {
 		axios.get.mockImplementation(() => {
-			return new Promise((resolve) => window.setTimeout(() => resolve({ data: { data: { show_hidden: true } } }), 400))
+			return new Promise((resolve) => window.setTimeout(() => resolve({ data: { data: { show_hidden: false } } }), 400))
 		})
-		const vue = await shallowMount(TestComponent)
-		expect(vue.vm.showHiddenFiles).toBe(false)
-		await vi.advanceTimersByTimeAsync(500)
+		const vue = shallowMount(TestComponent)
+		await nextTick()
+
 		expect(vue.vm.showHiddenFiles).toBe(true)
+		await vi.advanceTimersByTimeAsync(500)
+		await nextTick()
+		expect(vue.vm.showHiddenFiles).toBe(false)
 	})
 })
diff --git a/lib/composables/filesSettings.ts b/lib/composables/filesSettings.ts
index 63462c09..9c5e07e2 100644
--- a/lib/composables/filesSettings.ts
+++ b/lib/composables/filesSettings.ts
@@ -28,6 +28,10 @@ import { computed, onMounted, ref } from 'vue'
 
 import axios from '@nextcloud/axios'
 
+import { t } from '../utils/l10n'
+import { showError } from '../toast'
+import { useIsPublic } from './isPublic'
+
 interface OCAFilesUserConfig {
 	show_hidden: boolean
 	crop_image_previews: boolean
@@ -57,16 +61,27 @@ export type FileListViews = 'files'|'recent'|'favorites'
 export const useFilesSettings = () => {
 	const filesUserState = loadState<OCAFilesUserConfig|null>('files', 'config', null)
 
-	const showHiddenFiles = ref(filesUserState?.show_hidden ?? false)
+	const showHiddenFiles = ref(filesUserState?.show_hidden ?? true)
 	const sortFavoritesFirst = ref(filesUserState?.sort_favorites_first ?? true)
 	const cropImagePreviews = ref(filesUserState?.crop_image_previews ?? true)
 
-	onMounted(() => {
-		axios.get(generateUrl('/apps/files/api/v1/configs')).then((response) => {
-			showHiddenFiles.value = response.data?.data?.show_hidden ?? false
-			sortFavoritesFirst.value = response.data?.data?.sort_favorites_first ?? true
-			cropImagePreviews.value = response.data?.data?.crop_image_previews ?? true
-		})
+	const { isPublic } = useIsPublic()
+
+	onMounted(async () => {
+		if (!isPublic.value) {
+			try {
+				const { data } = await axios.get(generateUrl('/apps/files/api/v1/configs'))
+
+				showHiddenFiles.value = data?.data?.show_hidden ?? false
+				sortFavoritesFirst.value = data?.data?.sort_favorites_first ?? true
+				cropImagePreviews.value = data?.data?.crop_image_previews ?? true
+			} catch (error) {
+				console.error('Could not load files settings', error)
+				showError(t('Could not load files settings'))
+			}
+		} else {
+			console.debug('Skip loading files settings - currently on public share')
+		}
 	})
 
 	return {
@@ -98,21 +113,31 @@ export const useFilesViews = (currentView?: FileListViews|Ref<FileListViews>|Com
 		order: convertOrder(filesViewsState?.favorites?.sorting_direction ?? 'asc'),
 	})
 
-	onMounted(() => {
-		axios.get(generateUrl('/apps/files/api/v1/views')).then((response) => {
-			filesViewConfig.value = {
-				sortBy: response.data?.data?.files?.sorting_mode ?? 'basename',
-				order: convertOrder(response.data?.data?.files?.sorting_direction),
-			}
-			favoritesViewConfig.value = {
-				sortBy: response.data?.data?.favorites?.sorting_mode ?? 'basename',
-				order: convertOrder(response.data?.data?.favorites?.sorting_direction),
-			}
-			recentViewConfig.value = {
-				sortBy: response.data?.data?.recent?.sorting_mode ?? 'basename',
-				order: convertOrder(response.data?.data?.recent?.sorting_direction),
+	const { isPublic } = useIsPublic()
+
+	onMounted(async () => {
+		if (!isPublic.value) {
+			try {
+				const { data } = await axios.get(generateUrl('/apps/files/api/v1/views'))
+				filesViewConfig.value = {
+					sortBy: data?.data?.files?.sorting_mode ?? 'basename',
+					order: convertOrder(data?.data?.files?.sorting_direction),
+				}
+				favoritesViewConfig.value = {
+					sortBy: data?.data?.favorites?.sorting_mode ?? 'basename',
+					order: convertOrder(data?.data?.favorites?.sorting_direction),
+				}
+				recentViewConfig.value = {
+					sortBy: data?.data?.recent?.sorting_mode ?? 'basename',
+					order: convertOrder(data?.data?.recent?.sorting_direction),
+				}
+			} catch (error) {
+				console.error('Could not load files views', error)
+				showError(t('Could not load files views'))
 			}
-		})
+		} else {
+			console.debug('Skip loading files views - currently on public share')
+		}
 	})
 
 	const currentConfig = computed(() => toValue(currentView || 'files') === 'files' ? filesViewConfig.value : (toValue(currentView) === 'recent' ? recentViewConfig.value : favoritesViewConfig.value))
diff --git a/lib/composables/views.spec.ts b/lib/composables/views.spec.ts
new file mode 100644
index 00000000..8ecc834a
--- /dev/null
+++ b/lib/composables/views.spec.ts
@@ -0,0 +1,50 @@
+/**
+ * @copyright Copyright (c) 2024 Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @author Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @license AGPL-3.0-or-later
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import { describe, expect, it } from 'vitest'
+import { ref } from 'vue'
+import { useViews } from './views'
+
+describe('views composable', () => {
+	it('contains all views', () => {
+		const { allViews } = useViews(ref(false))
+		expect(allViews.length).toBe(3)
+		expect(allViews.find(({ id }) => id === 'files')).not.toBe(undefined)
+		expect(allViews.find(({ id }) => id === 'recent')).not.toBe(undefined)
+		expect(allViews.find(({ id }) => id === 'favorites')).not.toBe(undefined)
+	})
+
+	it('has all views on internal route', () => {
+		const { availableViews, allViews } = useViews(ref(false))
+		expect(allViews.length).toBe(3)
+		expect(availableViews.length).toBe(3)
+		for(const view of allViews) {
+			expect(availableViews.includes(view)).toBe(true)
+		}
+	})
+
+	it('has only the files views on public route', () => {
+		const { availableViews, allViews } = useViews(ref(true))
+		expect(allViews.length).toBe(3)
+		expect(availableViews.length).toBe(1)
+		expect(availableViews[0].id).toBe('files')
+	})
+})
diff --git a/lib/composables/views.ts b/lib/composables/views.ts
new file mode 100644
index 00000000..29eff829
--- /dev/null
+++ b/lib/composables/views.ts
@@ -0,0 +1,79 @@
+/**
+ * @copyright Copyright (c) 2024 Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @author Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @license AGPL-3.0-or-later
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import type { ComputedRef, Ref } from 'vue'
+
+import { mdiClock, mdiFolder, mdiStar } from '@mdi/js'
+import { t } from '../utils/l10n'
+
+export type IFilesViewId = 'files' | 'favorites' | 'recent'
+
+export interface IFilesView {
+	/**
+	 * Unique ID of the view
+	 */
+	id: IFilesViewId
+	/**
+	 * Localized name of the view
+	 */
+	label: string
+	/**
+	 * The SVG icon paths
+	 */
+	icon: string
+}
+
+/**
+ * Get available file views
+ */
+export const useViews = (isAnonymous: Ref<boolean> | ComputedRef<boolean>) => {
+
+	/**
+	 * All defined views
+	 */
+	const allViews = [
+		{
+			id: 'files',
+			label: t('All files'),
+			icon: mdiFolder,
+		},
+		{
+			id: 'recent',
+			label: t('Recent'),
+			icon: mdiClock,
+		},
+		{
+			id: 'favorites',
+			label: t('Favorites'),
+			icon: mdiStar,
+		},
+	] as IFilesView[]
+
+	/**
+	 * Views which are available for the current user
+	 */
+	const availableViews = isAnonymous.value ? allViews.filter(({ id }) => id === 'files') : allViews
+
+	return {
+		allViews,
+		availableViews,
+	}
+}
diff --git a/package-lock.json b/package-lock.json
index d52748b2..d0d407e8 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -9,6 +9,7 @@
       "version": "5.1.1",
       "license": "GPL-3.0-or-later",
       "dependencies": {
+        "@mdi/js": "^7.4.47",
         "@nextcloud/axios": "^2.4.0",
         "@nextcloud/event-bus": "^3.1.0",
         "@nextcloud/files": "^3.1.0",
@@ -3317,6 +3318,11 @@
         "unist-util-is": "^3.0.0"
       }
     },
+    "node_modules/@mdi/js": {
+      "version": "7.4.47",
+      "resolved": "https://registry.npmjs.org/@mdi/js/-/js-7.4.47.tgz",
+      "integrity": "sha512-KPnNOtm5i2pMabqZxpUz7iQf+mfrYZyKCZ8QNz85czgEt7cuHcGorWfdzUMWYA0SD+a6Hn4FmJ+YhzzzjkTZrQ=="
+    },
     "node_modules/@mdi/svg": {
       "version": "7.4.47",
       "resolved": "https://registry.npmjs.org/@mdi/svg/-/svg-7.4.47.tgz",
diff --git a/package.json b/package.json
index a9cd7225..db12d0ca 100644
--- a/package.json
+++ b/package.json
@@ -54,6 +54,7 @@
     "vue": "^2.7.16"
   },
   "dependencies": {
+    "@mdi/js": "^7.4.47",
     "@nextcloud/axios": "^2.4.0",
     "@nextcloud/event-bus": "^3.1.0",
     "@nextcloud/files": "^3.1.0",

From adfd9eebce3769f687abf1ee7ee70ece399769af Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 20 Feb 2024 20:37:56 +0100
Subject: [PATCH 3/4] fix(FilePicker): Cleanup code a bit

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 lib/components/FilePicker/FilePicker.vue | 27 +++++++++++-------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/lib/components/FilePicker/FilePicker.vue b/lib/components/FilePicker/FilePicker.vue
index 8d36cbf2..6d16fb1a 100644
--- a/lib/components/FilePicker/FilePicker.vue
+++ b/lib/components/FilePicker/FilePicker.vue
@@ -1,7 +1,17 @@
 <template>
-	<NcDialog v-bind="dialogProps" :open.sync="isOpen" @update:open="handleClose">
+	<NcDialog :container="container"
+		:buttons="dialogButtons"
+		:name="name"
+		size="large"
+		content-classes="file-picker__content"
+		dialog-classes="file-picker"
+		navigation-classes="file-picker__navigation"
+		:open.sync="isOpen"
+		@update:open="handleClose">
 		<template #navigation="{ isCollapsed }">
-			<FilePickerNavigation :is-collapsed="isCollapsed" :current-view.sync="currentView" :filter-string.sync="filterString" />
+			<FilePickerNavigation :is-collapsed="isCollapsed"
+				:current-view.sync="currentView"
+				:filter-string.sync="filterString" />
 		</template>
 
 		<div class="file-picker__main">
@@ -129,19 +139,6 @@ const { isPublic } = useIsPublic()
 
 const isOpen = ref(true)
 
-/**
- * Props to be passed to the underlying Dialog component
- */
-const dialogProps = computed(() => ({
-	container: props.container,
-	name: props.name,
-	buttons: dialogButtons.value,
-	size: 'large',
-	contentClasses: ['file-picker__content'],
-	dialogClasses: ['file-picker'],
-	navigationClasses: ['file-picker__navigation'],
-}))
-
 /**
  * Map buttons to Dialog buttons by wrapping the callback function to pass the selected files
  */

From 4857e5c56cb48993c906708aeef56e79317e71e0 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 20 Feb 2024 21:20:09 +0100
Subject: [PATCH 4/4] chore: Extract translations

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 l10n/messages.pot | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/l10n/messages.pot b/l10n/messages.pot
index 9b73f1f6..685520ec 100644
--- a/l10n/messages.pot
+++ b/l10n/messages.pot
@@ -34,6 +34,12 @@ msgstr ""
 msgid "Could not create the new folder"
 msgstr ""
 
+msgid "Could not load files settings"
+msgstr ""
+
+msgid "Could not load files views"
+msgstr ""
+
 msgid "Create directory"
 msgstr ""