Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited Text is not reloaded if switching from enlarged to sidebar view #2362

Closed
reox opened this issue Oct 6, 2020 · 7 comments
Closed

Edited Text is not reloaded if switching from enlarged to sidebar view #2362

reox opened this issue Oct 6, 2020 · 7 comments

Comments

@reox
Copy link
Contributor

reox commented Oct 6, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Create new card
  2. edit the description
  3. switch into enlarged view while still in edit (or into sidepanel view if already in enlarged view)
  4. description is empty
  5. reloading the page fixes it

Expected behavior
Description should be synced, even if switching views

Client details:

  • OS: Debian Buster, Windows 10
  • Browser: Chrome, Firefox

Deck 1.1.0 / NC 19.0.3

@juliushaertl juliushaertl added this to the 1.1.1 milestone Oct 7, 2020
@reox reox changed the title Edited Text is now reloaded if switching from enlarged to sidebar view Edited Text is not reloaded if switching from enlarged to sidebar view Oct 8, 2020
@budachst
Copy link

budachst commented Oct 9, 2020

My guess is, that the edited text didn't make it to the database. So I installed the latest nightly and that fixed the issue for me.

@juliushaertl
Copy link
Member

@budachst Not sure if this is the same issue, since we had nothing in the regard of this one where master differs from 1.1.0, yours could be however related to #2358

@budachst
Copy link

budachst commented Oct 9, 2020

Well, I actually can't tell. All I was noticing was that, added tags would only show up an page reoads, as well as editing the description of a card would first, show the same behaviour and second couldn't be edited a 2nd time.

I then checked the database and found, that further edits to the description field would not make it to the database. This was when I scanned the nightly build for resolved bugs and spotted something regarding database access, installed that and the issues were both gone.

@juliushaertl juliushaertl modified the milestones: 1.1.1, 1.1.2, 1.1.3 Oct 13, 2020
@juliushaertl juliushaertl modified the milestones: 1.1.3, 1.2.0, 1.2.1 Nov 11, 2020
@juliushaertl juliushaertl modified the milestones: 1.2.1, 1.2.2, 1.2.3 Nov 18, 2020
@reox
Copy link
Contributor Author

reox commented Nov 25, 2020

I just checked in 1.2.3 and it seems to be fixed? Can someone else confirm that too?
However the behavior changed: When changing from sidebar to modal while in edit mode, the modal view will now be in view mode.

@juliushaertl
Copy link
Member

Yes, should be fixed by ironing out some quirk where the sidebar was actually rendered twice (once hidden) when the modal was used.

However the behavior changed: When changing from sidebar to modal while in edit mode, the modal view will now be in view mode.

Would make sense to restore the old behaviour i think. Feel free to open a new issue for that.

@juliushaertl
Copy link
Member

Let's close. If anyone still encounters an issue, please let me know.

@reox
Copy link
Contributor Author

reox commented Nov 25, 2020

Would make sense to restore the old behaviour i think. Feel free to open a new issue for that.

Personally: I do not care :D I usually work only in the modal view nowadays, because I find it much more pleasing.

Thanks for fixing that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants