Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor frontend to remove second iframe #3011

Closed
1 of 10 tasks
juliushaertl opened this issue Jun 11, 2023 · 0 comments · Fixed by #3152
Closed
1 of 10 tasks

Refactor frontend to remove second iframe #3011

juliushaertl opened this issue Jun 11, 2023 · 0 comments · Fixed by #3152

Comments

@juliushaertl
Copy link
Member

I did a small PoC in https://github.com/nextcloud/richdocuments/compare/chore/refactor-iframe to remove the need for the separate document frame that is being loaded and instead load the Collabora page directly in the first iframe. Instead of loading the intermediate frame it just queries and endpoint to obtain the WOPI token and can then directly pass it to Collabora.

This has several benefits:

  • Reduces code complexity as we no longer need to proxy messages through two frames
  • No need to keep document state in two different script contexts
  • Speeds up loading time by a full page load with Nextcloud javascript

In general this works nicely, but needs a bit of work in order to make sure all previous functionality is still available:

  • Basic PoC for viewer usage
    • File creation from templates
  • Public share link (folder)
    • File creation from templates
  • Public share link (single file)
  • Direct editing logged in
    • File creation from templates
  • Direct editing share link
  • Federated editing
  • Make sure all post messages are handled as before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant