Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public share of a PDF file with download set to "hidden" does not open automatically #3871

Closed
elzody opened this issue Aug 3, 2024 · 0 comments · Fixed by #3872
Closed
Assignees

Comments

@elzody
Copy link
Contributor

elzody commented Aug 3, 2024

Describe the bug
When sharing a PDF via a public share link, it will not automatically open if the download button is set to be hidden. When this option is unchecked (download button will be shown), the PDF is displayed just fine, however.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any PDF on your instance
  2. Create a public share with "hide download" checked
  3. Open the public share
  4. The PDF will not be displayed

Expected behavior
The PDF will be displayed regardless, because there is no point in not showing it and also not being able to download it.

Details
The issue began on stable27 after I introduced #3600. Also, files.js seems to be legacy code and not needed, which I think caused the issue, since it was being loaded in addition to the public-share-handling public.js I introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant