Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: aria-label attribute cannot be used on a div with no valid role attribute. #42626

Closed
JuliaKirschenheuter opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 8, 2024

Screenshot from 2024-01-08 14-15-14

Implementation

<div data-v-ee6f34b5="" aria-label="MIME type image/png" class="_file-picker__file-icon_1vgv4_5" style="background-image: url(...);"></div>

<div data-v-ee6f34b5="" aria-label="MIME type text/markdown" class="_file-picker__file-icon_1vgv4_5" style="background-image: url(...);"><!----></div>

Note: aria-label is intended for use on interactive elements, or elements made to be interactive via other ARIA declarations, when there is no appropriate text visible in the DOM that could be referenced as a label
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label

Question: do we need this aria-label at all? @artonge @ShGKme ?

@JuliaKirschenheuter JuliaKirschenheuter added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility and removed enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 8, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jan 8, 2024

Question: do we need this aria-label at all? @artonge @ShGKme ?

I think, this would be good to have an image with a description here. This image helps to understand what type of file is here.

But I don't think, this is required (file name is still available). And that would not be easy to implement as any app can register new icon image for a new file type.

So I'd just remove it.

@JuliaKirschenheuter
Copy link
Contributor Author

closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Development

No branches or pull requests

3 participants