Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI option to configure an extra logo variant #47357

Open
elzody opened this issue Aug 20, 2024 · 1 comment
Open

Add UI option to configure an extra logo variant #47357

elzody opened this issue Aug 20, 2024 · 1 comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: theming

Comments

@elzody
Copy link
Contributor

elzody commented Aug 20, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
It has been previously discussed in nextcloud/richdocuments#2832 that, when using a custom logo which is white or black, it can be difficult to see when using Collabora. We have already added a workaround for this in nextcloud/richdocuments#3840 by allowing to set CSS variables using the custom theming app to control the logo background color or visibility, but this is simply a workaround.

Describe the solution you'd like
A proper solution would be to allow the user to set both a light and dark variant of their custom logo to be used when the logo would be otherwise difficult to see (for example, when using a white logo and opening Collabora in bright mode).

Describe alternatives you've considered
The alternatives considered are mentioned above with nextcloud/richdocuments#3840, but it's simply a workaround and doesn't provide a clear way to solve the issue. It would be better to present the option in the theming settings by default.

@elzody elzody added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 20, 2024
@juliushaertl
Copy link
Member

Additional note, this can also be useful for other places like the email template where a logo might be rendered on white background, currently we workaround there by adding a small pill with the primary color around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: theming
Projects
Status: 🧭 Planning evaluation / ideas
Development

No branches or pull requests

3 participants