Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions CI - use include for old Nextflow version #1081

Open
ewels opened this issue May 14, 2021 · 0 comments
Open

Actions CI - use include for old Nextflow version #1081

ewels opened this issue May 14, 2021 · 0 comments
Labels
good-first-issue linting template nf-core pipeline/component template

Comments

@ewels
Copy link
Member

ewels commented May 14, 2021

All @nf-core pipelines must test two versions of Nextflow - the minimum required by the pipeline and the latest release.

However, it's quite common for pipelines to test multiple config profiles as well. With the normal job matrix setup this means that all test profiles are run twice, for both versions of Nextflow. This is probably overkill.

A nicer method is to use the include keyword to inject the old Nextflow version run for just the test profile as I did here: https://github.com/nf-core/diaproteomics/pull/131/files

If we like this, need to update the linting tests to allow this. Could even also update the template and make the lint tests force this style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue linting template nf-core pipeline/component template
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants