Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

Still too much logic in the views #184

Open
neilbmclaughlin opened this issue Jul 18, 2017 · 0 comments
Open

Still too much logic in the views #184

neilbmclaughlin opened this issue Jul 18, 2017 · 0 comments

Comments

@neilbmclaughlin
Copy link
Contributor

Depending on state, the values of the header, contextual text and form class tag change but the presence of the elements themselves in app/views/includes/search-form.nunjucks do not.

Much of the conditional code, which at present is spread between the render and preRender middleware and the view template, could be consolidated into the testable messages lib with it's purpose to populate an object of heading, text and class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant