Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CheckoutCard getState #416

Open
danimoh opened this issue Apr 19, 2020 · 0 comments
Open

Refactor CheckoutCard getState #416

danimoh opened this issue Apr 19, 2020 · 0 comments
Assignees

Comments

@danimoh
Copy link
Member

danimoh commented Apr 19, 2020

As the CheckoutServerApi.getState request does not depend on the currency type anymore (see #412), it does not make sense anymore that the CheckoutCards for every coin separately fetch and update the state. Instead, the Checkout view can take care of this and forward the updated state to the CheckoutCards. Same for syncing to server time.

Also, currently it doesn't make too much sense that the overpayment / underpayment logic is in the CheckoutCard base class as its only used for BTC and ETH. As this would change with #415 though, this should already be taken into consideration when refactoring the state update.

@danimoh danimoh self-assigned this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant